From: asmadeus@codewreck.org
To: "Guozihua (Scott)" <guozihua@huawei.com>
Cc: Christian Schoenebeck <linux_oss@crudebyte.com>,
ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 0/3 v2] 9p: Fix write overflow in p9_read_work
Date: Fri, 18 Nov 2022 22:57:14 +0900 [thread overview]
Message-ID: <Y3ePOhpctTf7Buf8@codewreck.org> (raw)
In-Reply-To: <a6aec93a-1166-1d8a-48de-767bc1eb2214@huawei.com>
Guozihua (Scott) wrote on Fri, Nov 18, 2022 at 06:18:16PM +0800:
> I retried the repro on your branch, the issue does not reproduce. What
> a good pair of eyes :)！
Thanks!
By the way the original check also compared size to msize directly,
without an offset for headers, so with hindsight it looks clear enough
that the size is the full size including the header.
I'm not sure why I convinced myself it didn't...
Anyway, this made me check other places where we might fail at this and
I've a couple more patches; please review if you have time.
I'll send them all to Linus next week...
--
Dominique
next prev parent reply other threads:[~2022-11-18 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 9:11 [PATCH 0/3 v2] 9p: Fix write overflow in p9_read_work GUO Zihua
2022-11-17 9:11 ` [PATCH 1/3 " GUO Zihua
2022-11-17 9:11 ` [PATCH 2/3 v2] 9p: Remove redundent checks for message size against msize GUO Zihua
2022-11-17 9:11 ` [PATCH 3/3 v2] 9p: Use P9_HDRSZ for header size GUO Zihua
2022-11-17 10:49 ` [PATCH 0/3 v2] 9p: Fix write overflow in p9_read_work asmadeus
2022-11-17 10:54 ` Guozihua (Scott)
2022-11-17 13:33 ` Christian Schoenebeck
2022-11-18 4:59 ` asmadeus
2022-11-18 10:18 ` Guozihua (Scott)
2022-11-18 13:57 ` asmadeus [this message]
2022-11-18 15:34 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3ePOhpctTf7Buf8@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=guozihua@huawei.com \
--cc=kuba@kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).