Re: [PATCH v2 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove redundant ALE_CLEAR

Maciej Fijalkowski
2022-11-22T11:47:30Z

On Tue, Nov 22, 2022 at 02:02:29AM +0100, Andrew Lunn wrote:
> On Mon, Nov 21, 2022 at 06:51:05PM +0100, Maciej Fijalkowski wrote:
> > On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote:
> > > ALE_CLEAR command is issued in cpsw_ale_start() so no need
> > > to issue it before the call to cpsw_ale_start().
> > >
> > > Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support")
> >
> > Not a fix to me, can you send it to -next tree? As you said, it's an
> > optimization.
>
> commit fd23df72f2be317d38d9fde0a8996b8e7454fd2a
> Author: Roger Quadros <rogerq@kernel.org>
> Date: Fri Nov 4 15:23:07 2022 +0200
>
> The change being fixed is in net-next.

Ah right, nevertheless I had some comments there.

>
> Roger, please take a look at the netdev FAQ and fix your Subject line.
>
> Andrew