From: Jiri Pirko <jiri@resnulli.us>
To: Nikolay Borisov <nikolay.borisov@virtuozzo.com>
Cc: nhorman@tuxdriver.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, den@virtuozzo.com,
khorenko@virtuozzo.com
Subject: Re: [PATCH net-next 1/3] drop_monitor: Implement namespace filtering/reporting for software drops
Date: Mon, 21 Nov 2022 15:24:53 +0100 [thread overview]
Message-ID: <Y3uKNf53EkKMmVwh@nanopsycho> (raw)
In-Reply-To: <20221121133132.1837107-2-nikolay.borisov@virtuozzo.com>
Mon, Nov 21, 2022 at 02:31:30PM CET, nikolay.borisov@virtuozzo.com wrote:
[...]
>diff --git a/include/uapi/linux/net_dropmon.h b/include/uapi/linux/net_dropmon.h
>index 84f622a66a7a..016c36b531da 100644
>--- a/include/uapi/linux/net_dropmon.h
>+++ b/include/uapi/linux/net_dropmon.h
>@@ -8,6 +8,7 @@
> struct net_dm_drop_point {
> __u8 pc[8];
> __u32 count;
>+ __u32 ns_id;
> };
>
> #define is_drop_point_hw(x) do {\
>@@ -82,6 +83,7 @@ enum net_dm_attr {
> NET_DM_ATTR_TRUNC_LEN, /* u32 */
> NET_DM_ATTR_ORIG_LEN, /* u32 */
> NET_DM_ATTR_QUEUE_LEN, /* u32 */
>+ NET_DM_ATTR_NS, /* u32 */
I believe that we need to add a CI warning for this kind of UAPI
breakage...
> NET_DM_ATTR_STATS, /* nested */
> NET_DM_ATTR_HW_STATS, /* nested */
> NET_DM_ATTR_ORIGIN, /* u16 */
next prev parent reply other threads:[~2022-11-21 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:31 [PATCH net-next 0/3] Add support for netnamespace filtering in drop monitor Nikolay Borisov
2022-11-21 13:31 ` [PATCH net-next 1/3] drop_monitor: Implement namespace filtering/reporting for software drops Nikolay Borisov
2022-11-21 14:24 ` Jiri Pirko [this message]
2022-11-21 20:23 ` Jakub Kicinski
2022-11-21 13:31 ` [PATCH net-next 2/3] drop_monitor: Add namespace filtering/reporting for hardware drops Nikolay Borisov
2022-11-21 13:31 ` [PATCH net-next 3/3] selftests: net: Add drop monitor tests for namespace filtering functionality Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3uKNf53EkKMmVwh@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=den@virtuozzo.com \
--cc=khorenko@virtuozzo.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nikolay.borisov@virtuozzo.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox