From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
Sean Anderson <sean.anderson@seco.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next] net: phy: swphy: Support all normal speeds when link down
Date: Mon, 5 Dec 2022 16:04:21 +0000 [thread overview]
Message-ID: <Y44WhXU+Lq+MEM7A@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221204174103.1033005-1-andrew@lunn.ch>
On Sun, Dec 04, 2022 at 06:41:03PM +0100, Andrew Lunn wrote:
> The software PHY emulator validation function is happy to accept any
> link speed if the link is down. swphy_read_reg() however triggers a
> WARN_ON(). Change this to report all the standard 1G link speeds are
> supported. Once the speed is known the supported link modes will
> change, which is a bit odd, but for emulation is probably O.K.
>
> Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
This isn't what I suggested. I suggested restoring the old behaviour of
fixed_phy before commit 5ae68b0ce134 ("phy: move fixed_phy MII register
generation to a library") which did _not_ report all speeds, but
reported no supported speeds in BMSR.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-12-05 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 17:41 [PATCH net-next] net: phy: swphy: Support all normal speeds when link down Andrew Lunn
2022-12-05 15:28 ` Sean Anderson
2022-12-05 16:04 ` Russell King (Oracle) [this message]
2022-12-05 16:44 ` Andrew Lunn
2022-12-05 16:50 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y44WhXU+Lq+MEM7A@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).