From: Andrew Lunn <andrew@lunn.ch>
To: Divya Koppera <Divya.Koppera@microchip.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
richardcochran@gmail.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR
Date: Tue, 6 Dec 2022 14:07:56 +0100 [thread overview]
Message-ID: <Y48+rLpF7Gre/s1P@lunn.ch> (raw)
In-Reply-To: <20221206073511.4772-3-Divya.Koppera@microchip.com>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 1bcdb828db56..650ef53fcf20 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -3017,10 +3017,6 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev)
> {
> struct lan8814_shared_priv *shared = phydev->shared->priv;
>
> - if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
> - !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
> - return 0;
> -
Why are you removing this ?
Andrew
next prev parent reply other threads:[~2022-12-06 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 7:35 [PATCH v5 net-next 0/2] Fixed warnings Divya Koppera
2022-12-06 7:35 ` [PATCH v5 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Divya Koppera
2022-12-06 9:09 ` Jiri Pirko
2022-12-06 7:35 ` [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR Divya Koppera
2022-12-06 13:07 ` Andrew Lunn [this message]
2022-12-06 13:45 ` Divya.Koppera
2022-12-06 14:08 ` Andrew Lunn
2022-12-06 16:39 ` Richard Cochran
2022-12-12 8:34 ` Divya.Koppera
2022-12-12 10:11 ` Andrew Lunn
2022-12-13 9:55 ` Divya.Koppera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y48+rLpF7Gre/s1P@lunn.ch \
--to=andrew@lunn.ch \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).