From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAD6C352A1 for ; Tue, 6 Dec 2022 12:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232543AbiLFMam (ORCPT ); Tue, 6 Dec 2022 07:30:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231888AbiLFMak (ORCPT ); Tue, 6 Dec 2022 07:30:40 -0500 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71EFD28E2C; Tue, 6 Dec 2022 04:30:38 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D970C32009D6; Tue, 6 Dec 2022 07:30:36 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 06 Dec 2022 07:30:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1670329836; x=1670416236; bh=jE2AKhiday7rIVXVatfMZmacEC94 FeR0G3T3H1swJ8Y=; b=Ny7jLi5P8j4TjF5rVK3gvSYaXgEW6vskaSmN3qdDP2iQ 5nmHAUY5r8RySL+guzL//8B9pYMy5aASBysH0BW4/wlAsJDqvAtHMKL3ABnsQgSa BMgKqhJgI36dhqlYSsQgcvyGxhPtaWJL1SqaUkDBV7gI+qezOd4AidpS964O90A0 zogMaWgu/FfmN7aD8YJi+Os6W/viOxWlCYkqIPeh1DpbhXUc7YZA3aspKRyD4TTS 3BnjrlpyuAXZhPfkytGsj2d9cGOrYa8Qi8e3yRF9N1TFGEm3CLyt7BWKsD6qdl/K Li7NE1Ul/MR80TvoctNk3f4qZcxP+PoC1qtRdMN2dg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeigdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedvudefveekheeugeeftddvveefgfduieefudeifefgleekheegleegjeejgeeg hfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Dec 2022 07:30:34 -0500 (EST) Date: Tue, 6 Dec 2022 14:30:29 +0200 From: Ido Schimmel To: "Hans J. Schultz" Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , Eric Dumazet , Paolo Abeni , open list Subject: Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags Message-ID: References: <20221205185908.217520-1-netdev@kapio-technology.com> <20221205185908.217520-3-netdev@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221205185908.217520-3-netdev@kapio-technology.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 05, 2022 at 07:59:07PM +0100, Hans J. Schultz wrote: > The default return value -EOPNOTSUPP of mv88e6xxx_port_bridge_flags() > came from the return value of the DSA method port_egress_floods() in > commit 4f85901f0063 ("net: dsa: mv88e6xxx: add support for bridge flags"), > but the DSA API was changed in commit a8b659e7ff75 ("net: dsa: act as > passthrough for bridge port flags"), resulting in the return value > -EOPNOTSUPP not being valid anymore. The commit message needs to explain the motivation for the change and why the change is not a bug fix / safe. I guess the motivation is the next patch where a change in the MAB flag cannot fail and therefore it has no reason to reset the 'err' variable. The change is only safe if upper layers only invoke the operation when supported bridge port flags are changed. That is, the default error code is never used.