Re: [PATCH net-next V3 7/8] devlink: Expose port function commands to control migratable

[Jiri Pirko <jiri@resnulli.us>]

Tue, Dec 06, 2022 at 12:37:44AM CET, shnelson@amd.com wrote:
>On 12/4/22 6:16 AM, Shay Drory wrote:
>> Expose port function commands to enable / disable migratable
>> capability, this is used to set the port function as migratable.
>
>Since most or the devlink attributes, parameters, etc are named as nouns or
>verbs (e.g. roce, running, rate, err_count, enable_sriov, etc), seeing this
>term in an adjective form is a bit jarring.  This may seem like a picky
>thing, but can we use "migrate" or "migration" throughout this patch rather
>than "migratable"?

But it is about "ability to migrate". That from how I understand the
language, "migratable" describes the best, doesn't it?


>
>> 
>> Live migration is the process of transferring a live virtual machine
>> from one physical host to another without disrupting its normal
>> operation.
>> 
>> In order for a VM to be able to perform LM, all the VM components must
>> be able to perform migration. e.g.: to be migratable.
>> In order for VF to be migratable, VF must be bound to VFIO driver with
>> migration support.
>> 
>> When migratable capability is enable for a function of the port, the
>
>s/enable/enabled/
>
>
>
>> 
>> diff --git a/include/net/devlink.h b/include/net/devlink.h
>> index 20306fb8a1d9..fdb5e8da33ce 100644
>> --- a/include/net/devlink.h
>> +++ b/include/net/devlink.h
>> @@ -1470,6 +1470,27 @@ struct devlink_ops {
>>          int (*port_function_roce_set)(struct devlink_port *devlink_port,
>>                                        bool enable,
>>                                        struct netlink_ext_ack *extack);
>> +       /**
>> +        * @port_function_mig_get: Port function's migratable get function.
>
>I would prefer to see 'mig' spelled out as 'migration'
>
>sln