From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Veerasenareddy Burru <vburru@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liron Himi <lironh@marvell.com>,
Abhijit Ayarekar <aayarekar@marvell.com>,
Sathesh B Edara <sedara@marvell.com>,
Satananda Burla <sburla@marvell.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control messages
Date: Tue, 6 Dec 2022 10:58:47 +0200 [thread overview]
Message-ID: <Y48ERxYICkG9lQc1@unreal> (raw)
In-Reply-To: <20221205161626.088e383f@kernel.org>
On Mon, Dec 05, 2022 at 04:16:26PM -0800, Jakub Kicinski wrote:
> On Mon, 5 Dec 2022 10:10:34 +0200 Leon Romanovsky wrote:
> > > These messages include periodic keep alive (heartbeat) messages
> > > from FW and control messages from VFs. Every PF will be listening
> > > for its own control messages.
> >
> > @netdev, as I said, I don't know if it is valid behaviour in netdev.
> > Can you please comment?
>
> Polling for control messages every 100ms? Sure.
>
> You say "valid in netdev" so perhaps you can educate us where/why it
> would not be?
It doesn't seem right to me that idle device burns CPU cycles, while it
supports interrupts. If it needs "listen to FW", it will be much nicer to
install interrupts immediately and don't wait for netdev.
Thanks
next prev parent reply other threads:[~2022-12-06 8:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 13:09 [PATCH net-next v2 0/9] octeon_ep: Update PF mailbox for VF Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 1/9] octeon_ep: defer probe if firmware not ready Veerasenareddy Burru
2022-11-30 9:24 ` Leon Romanovsky
2022-11-30 15:50 ` [EXT] " Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 2/9] octeon_ep: poll for control messages Veerasenareddy Burru
2022-11-30 9:30 ` Leon Romanovsky
2022-11-30 15:44 ` [EXT] " Veerasenareddy Burru
2022-12-01 8:11 ` Leon Romanovsky
2022-12-05 4:46 ` Veerasenareddy Burru
2022-12-05 8:10 ` Leon Romanovsky
2022-12-06 0:16 ` Jakub Kicinski
2022-12-06 8:58 ` Leon Romanovsky [this message]
2022-12-06 17:23 ` Jakub Kicinski
2022-12-06 21:19 ` Veerasenareddy Burru
2022-12-07 1:26 ` Jakub Kicinski
2022-12-08 3:17 ` Veerasenareddy Burru
2022-12-08 4:02 ` Jakub Kicinski
2022-12-08 4:41 ` Veerasenareddy Burru
2022-12-08 4:47 ` Jakub Kicinski
2022-12-14 7:15 ` Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 3/9] octeon_ep: control mailbox for multiple PFs Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 4/9] octeon_ep: enhance control mailbox for VF support Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 5/9] octeon_ep: support asynchronous notifications Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 6/9] octeon_ep: control mbox support for VF stats and link info Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 7/9] octeon_ep: add SRIOV VF creation Veerasenareddy Burru
2022-11-29 13:09 ` [PATCH net-next v2 8/9] octeon_ep: add PF-VF mailbox communication Veerasenareddy Burru
2022-12-09 8:48 ` Dan Carpenter
2022-11-29 13:09 ` [PATCH net-next v2 9/9] octeon_ep: add heartbeat monitor Veerasenareddy Burru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y48ERxYICkG9lQc1@unreal \
--to=leon@kernel.org \
--cc=aayarekar@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lironh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).