From: Leon Romanovsky <leon@kernel.org>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: wangchuanlei <wangchuanlei@inspur.com>,
alexandr.lobakin@intel.com, pabeni@redhat.com, pshelar@ovn.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
wangpeihui@inspur.com, netdev@vger.kernel.org,
dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH v7 net-next] net: openvswitch: Add support to count upcall packets
Date: Tue, 6 Dec 2022 11:54:31 +0200 [thread overview]
Message-ID: <Y48RV9j4WRUcsuYV@unreal> (raw)
In-Reply-To: <E969E975-1D24-48F1-949E-3D5EE27AFA02@redhat.com>
On Tue, Dec 06, 2022 at 09:12:01AM +0100, Eelco Chaudron wrote:
>
>
> On 5 Dec 2022, at 4:00, wangchuanlei wrote:
>
> > Add support to count upall packets, when kmod of openvswitch
> > upcall to userspace , here count the number of packets for
> > upcall succeed and failed, which is a better way to see how
> > many packets upcalled to userspace(ovs-vswitchd) on every
> > interfaces.
>
> Thanks for including my suggestions, one more comment below.
>
> > Here modify format of code used by comments of v6.
> >
> > Changes since v4 & v5 & v6:
> > - optimize the function used by comments
> >
> > Changes since v3:
> > - use nested NLA_NESTED attribute in netlink message
> >
> > Changes since v2:
> > - add count of upcall failed packets
> >
> > Changes since v1:
> > - add count of upcall succeed packets
Please put changelog after "---". It doesn't belong to commit message.
Thanks
> >
> > Signed-off-by: wangchuanlei <wangchuanlei@inspur.com>
> > ---
prev parent reply other threads:[~2022-12-06 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 3:00 [PATCH] [PATCH v7 net-next] net: openvswitch: Add support to count upcall packets wangchuanlei
2022-12-06 8:12 ` Eelco Chaudron
2022-12-06 9:54 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y48RV9j4WRUcsuYV@unreal \
--to=leon@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=wangchuanlei@inspur.com \
--cc=wangpeihui@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).