* [PATCH net-next] net/mlx5: remove redundant ret variable
@ 2022-12-05 6:24 zhang.songyi
2022-12-05 8:10 ` Roi Dayan
2022-12-06 13:21 ` Jiri Pirko
0 siblings, 2 replies; 3+ messages in thread
From: zhang.songyi @ 2022-12-05 6:24 UTC (permalink / raw)
To: leon
Cc: saeedm, davem, edumazet, kuba, pabeni, kliteyn, shunh, rongweil,
valex, zhang.songyi, netdev, linux-rdma, linux-kernel
From: zhang songyi <zhang.songyi@zte.com.cn>
Return value from mlx5dr_send_postsend_action() directly instead of taking
this in another redundant variable.
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
index a4476cb4c3b3..fd2d31cdbcf9 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
@@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
struct mlx5dr_action *action)
{
struct postsend_info send_info = {};
- int ret;
send_info.write.addr = (uintptr_t)action->rewrite->data;
send_info.write.length = action->rewrite->num_of_actions *
@@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
mlx5dr_icm_pool_get_chunk_mr_addr(action->rewrite->chunk);
send_info.rkey = mlx5dr_icm_pool_get_chunk_rkey(action->rewrite->chunk);
- ret = dr_postsend_icm_data(dmn, &send_info);
-
- return ret;
+ return dr_postsend_icm_data(dmn, &send_info);
}
static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev,
--
2.15.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/mlx5: remove redundant ret variable
2022-12-05 6:24 [PATCH net-next] net/mlx5: remove redundant ret variable zhang.songyi
@ 2022-12-05 8:10 ` Roi Dayan
2022-12-06 13:21 ` Jiri Pirko
1 sibling, 0 replies; 3+ messages in thread
From: Roi Dayan @ 2022-12-05 8:10 UTC (permalink / raw)
To: zhang.songyi, leon
Cc: saeedm, davem, edumazet, kuba, pabeni, kliteyn, shunh, rongweil,
valex, netdev, linux-rdma, linux-kernel
On 05/12/2022 8:24, zhang.songyi@zte.com.cn wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return value from mlx5dr_send_postsend_action() directly instead of taking
> this in another redundant variable.
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> index a4476cb4c3b3..fd2d31cdbcf9 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> @@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
> struct mlx5dr_action *action)
> {
> struct postsend_info send_info = {};
> - int ret;
>
> send_info.write.addr = (uintptr_t)action->rewrite->data;
> send_info.write.length = action->rewrite->num_of_actions *
> @@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
> mlx5dr_icm_pool_get_chunk_mr_addr(action->rewrite->chunk);
> send_info.rkey = mlx5dr_icm_pool_get_chunk_rkey(action->rewrite->chunk);
>
> - ret = dr_postsend_icm_data(dmn, &send_info);
> -
> - return ret;
> + return dr_postsend_icm_data(dmn, &send_info);
> }
>
> static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev,
Reviewed-by: Roi Dayan <roid@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/mlx5: remove redundant ret variable
2022-12-05 6:24 [PATCH net-next] net/mlx5: remove redundant ret variable zhang.songyi
2022-12-05 8:10 ` Roi Dayan
@ 2022-12-06 13:21 ` Jiri Pirko
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2022-12-06 13:21 UTC (permalink / raw)
To: zhang.songyi
Cc: leon, saeedm, davem, edumazet, kuba, pabeni, kliteyn, shunh,
rongweil, valex, netdev, linux-rdma, linux-kernel
Mon, Dec 05, 2022 at 07:24:01AM CET, zhang.songyi@zte.com.cn wrote:
>From: zhang songyi <zhang.songyi@zte.com.cn>
>
>Return value from mlx5dr_send_postsend_action() directly instead of taking
>this in another redundant variable.
>
>Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-06 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-05 6:24 [PATCH net-next] net/mlx5: remove redundant ret variable zhang.songyi
2022-12-05 8:10 ` Roi Dayan
2022-12-06 13:21 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).