From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EC0C4321E for ; Mon, 28 Nov 2022 19:56:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231278AbiK1T4H (ORCPT ); Mon, 28 Nov 2022 14:56:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232931AbiK1T4A (ORCPT ); Mon, 28 Nov 2022 14:56:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B16982CDD2 for ; Mon, 28 Nov 2022 11:55:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D9F261374 for ; Mon, 28 Nov 2022 19:55:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99B84C433D6; Mon, 28 Nov 2022 19:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669665358; bh=5pAAqgucWmZwaxI3Czew9/kFWeWcPacMykeGnJ1HBT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SY+e5/C/uT3qB6PkugblzWxwoK1CyeZlaZwcW6AapM1rDc6vVKjsidE8rzt3bAdWg hQGEwmu7ml/lAv5h7DfPojYNp4YKy/Sl0KBmxEIl4m0ebLc0l5y6NmFXcaAxnTqOqj f46MZFtgUg77K5Z2/A5j8FEqXZkSiGfy+xonEn3lObSBq2mBvskWCSWPFaVpFlo7Ce w6iVTsWx1WhEBBdEZlwYnZbb/J15R1TkncGq9uOmV7WUkOeLjOIdatBRbjtCgZ+KFh mfFRZwU9e++17inASO8qJQcsp+IBwoHPMoq1SstR/RMQ0Arckh8Ddvoz1sra657Pxq 0BSoXOSSR6k+Q== Date: Mon, 28 Nov 2022 11:55:57 -0800 From: Saeed Mahameed To: Tariq Toukan Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , YueHaibing Subject: Re: [net 07/15] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create() Message-ID: References: <20221124081040.171790-1-saeed@kernel.org> <20221124081040.171790-8-saeed@kernel.org> <822ae1fd-c059-d834-60a0-af0dc944ff9f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <822ae1fd-c059-d834-60a0-af0dc944ff9f@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 24 Nov 10:32, Tariq Toukan wrote: > > >On 11/24/2022 10:10 AM, Saeed Mahameed wrote: >>From: YueHaibing >> >>'accel_tcp' is allocated by kvzalloc(), which should freed by kvfree(). >> >>Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API") >>Signed-off-by: YueHaibing >>Reviewed-by: Tariq Toukan >>Signed-off-by: Saeed Mahameed >>--- > >Hi Saeed, >There was a v3 of this, that changes the alloc side instead. > Thanks Tariq, that patch was Marked for -next for some reason, and it's in my net-next queue, i think it's ok if this went to net and the other to net-next.