From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA70C46467 for ; Tue, 29 Nov 2022 13:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234391AbiK2NnX (ORCPT ); Tue, 29 Nov 2022 08:43:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234303AbiK2NnO (ORCPT ); Tue, 29 Nov 2022 08:43:14 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3789E186E9 for ; Tue, 29 Nov 2022 05:43:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fpudl/FnftKRMrJTxTTTWeziSsjQ4C+kADcLeoKlYyw=; b=vCNS4uip8oP57GIdEkmBp7YVdH 3WcP5Oxx/klmqL7Kz/ywDnKwcVQw0ADgmVhMsDDzQxAW7rzjgTknyVun/C2e8UPeETxBQWk1c8n6l 34k6MYwsZOze7g5jBHXze2kk+cM2p38FWq6PFMBRPKnDr44pLTQZz174iseKrFMSoCFCX4DSN3S0H gmsKfDQBSgqwtcpRxsxWK+4mCJ5qRqKSYBHTdMbLq0YmCW7oa6Zg90AExhvhlQ5tLVXjM5ve7JbCC +HGjQ/DgEuiuywhwmAmyZoufj8SWxhvhdxcFHuWZMl/3Z1MmJGOiJMdAMNf/tIQJ6bl/JWTvPmPpC S/ON2IOQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35476) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p00t8-0000jx-G9; Tue, 29 Nov 2022 13:43:06 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p00t7-0001ar-Em; Tue, 29 Nov 2022 13:43:05 +0000 Date: Tue, 29 Nov 2022 13:43:05 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean , Andrew Lunn Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Florian Fainelli , UNGLinuxDriver@microchip.com, bcm-kernel-feedback-list@broadcom.com, Madalin Bucur , Camelia Groza , Claudiu Manoil , Ioana Ciornei , Maxim Kochetkov , Sean Anderson , Antoine Tenart , Michael Walle , Raag Jadav , Siddharth Vadapalli , Ong Boon Leong , Colin Foster , Marek Behun Subject: Re: [PATCH v4 net-next 3/8] net: phy: bcm84881: move the in-band capability check where it belongs Message-ID: References: <20221122175603.soux2q2cxs2wfsun@skbuf> <20221122193618.p57qrvhymeegu7cs@skbuf> <20221125123022.cnqobhnuzyqb5ukw@skbuf> <20221125153555.uzrl7j2me3lh2aeg@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 29, 2022 at 01:40:58PM +0000, Russell King (Oracle) wrote: > Here's an updated patch. > 8<=== > From: "Russell King (Oracle)" > Subject: [PATCH] net: phy: marvell: add validate_an_inband() method > > Add the validate_an_inband() method for Marvell 88E1111, the Finisar > version of the 88E1111, and 88E1112. > > Signed-off-by: Russell King (Oracle) And this is what I was using on top to force a mismatch with bypass enabled: diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index fbf881cd4a38..c7a0389320cd 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -683,6 +683,14 @@ static int m88e1111_validate_an_inband(struct phy_device *phydev, if (extsr < 0 || bmcr < 0) return PHY_AN_INBAND_UNKNOWN; + /* <<=== HACK */ + phydev_info(phydev, "extsr: %04x fiber bmcr: %04x\n", extsr, bmcr); + phy_write(phydev, MII_M1111_PHY_EXT_SR, extsr | + MII_M1111_HWCFG_SERIAL_AN_BYPASS); + genphy_soft_reset(phydev); + return PHY_AN_INBAND_OFF; + /* ===>> HACK */ + /* We make no efforts to enable the ANENABLE bit when switching mode. * If this bit is clear, then we will not be using in-band signalling. */ -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!