From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com
Subject: Re: [patch net-next v2] net: devlink: convert port_list into xarray
Date: Wed, 30 Nov 2022 09:48:20 +0100 [thread overview]
Message-ID: <Y4cY1DIKYkwLA8ul@nanopsycho> (raw)
In-Reply-To: <20221129212736.60d3bb4b@kernel.org>
Wed, Nov 30, 2022 at 06:27:36AM CET, kuba@kernel.org wrote:
>On Mon, 28 Nov 2022 12:08:03 +0100 Jiri Pirko wrote:
>> @@ -9903,9 +9896,9 @@ void devlink_free(struct devlink *devlink)
>> WARN_ON(!list_empty(&devlink->sb_list));
>> WARN_ON(!list_empty(&devlink->rate_list));
>> WARN_ON(!list_empty(&devlink->linecard_list));
>> - WARN_ON(!list_empty(&devlink->port_list));
>>
>> xa_destroy(&devlink->snapshot_ids);
>> + xa_destroy(&devlink->ports);
>
>Will it warn if not empty? Should we keep the warning ?
I don't think so.
Will add the warning in next V.
next prev parent reply other threads:[~2022-11-30 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 11:08 [patch net-next v2] net: devlink: convert port_list into xarray Jiri Pirko
2022-11-30 5:27 ` Jakub Kicinski
2022-11-30 8:48 ` Jiri Pirko [this message]
2022-11-30 9:03 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4cY1DIKYkwLA8ul@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox