From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Tirthendu Sarkar <tirthendu.sarkar@intel.com>
Cc: <bjorn@kernel.org>, <magnus.karlsson@intel.com>,
<jonathan.lemon@gmail.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests: xsk: changes for setting up NICs to run xsk self-tests
Date: Wed, 30 Nov 2022 12:57:59 +0100 [thread overview]
Message-ID: <Y4dFR9oR3AAIcPlB@boxer> (raw)
In-Reply-To: <20221130094142.545051-1-tirthendu.sarkar@intel.com>
On Wed, Nov 30, 2022 at 03:11:42PM +0530, Tirthendu Sarkar wrote:
> ETH devies need to be set up for running xsk self-tests, like enable
> loopback, set promiscuous mode, MTU etc. This patch adds those settings
> before running xsk self-tests and reverts them back once done.
>
> Signed-off-by: Tirthendu Sarkar <tirthendu.sarkar@intel.com>
> ---
> tools/testing/selftests/bpf/test_xsk.sh | 27 ++++++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh
> index d821fd098504..e7a5c5fc4f71 100755
> --- a/tools/testing/selftests/bpf/test_xsk.sh
> +++ b/tools/testing/selftests/bpf/test_xsk.sh
> @@ -106,7 +106,11 @@ MTU=1500
> trap ctrl_c INT
>
> function ctrl_c() {
> - cleanup_exit ${VETH0} ${VETH1} ${NS1}
> + if [ ! -z $ETH ]; then
> + cleanup_exit ${VETH0} ${VETH1} ${NS1}
> + else
> + cleanup_eth
> + fi
> exit 1
> }
>
> @@ -138,9 +142,28 @@ setup_vethPairs() {
> ip link set ${VETH0} up
> }
>
> +setup_eth() {
> + sudo ethtool -L ${ETH} combined 1
what if particular device has a different way of configuring single
channel? like
$ sudo ethtool -L ${ETH} tx 1 rx 1
I am not sure if we want to proceed with settings that are specific to
Intel devices. What if mlx5 will this in a much different way?
> + sudo ethtool -K ${ETH} loopback on
> + sudo ip link set ${ETH} promisc on
> + sudo ip link set ${ETH} mtu ${MTU}
> + sudo ip link set ${ETH} up
> + IPV6_DISABLE_CMD="sudo sysctl -n net.ipv6.conf.${ETH}.disable_ipv6"
> + IPV6_DISABLE=`$IPV6_DISABLE_CMD 2> /dev/null`
> + [[ $IPV6_DISABLE == "0" ]] && $IPV6_DISABLE_CMD=1
> + sleep 1
> +}
> +
> +cleanup_eth() {
> + [[ $IPV6_DISABLE == "0" ]] && $IPV6_DISABLE_CMD=0
> + sudo ethtool -K ${ETH} loopback off
> + sudo ip link set ${ETH} promisc off
> +}
> +
> if [ ! -z $ETH ]; then
> VETH0=${ETH}
> VETH1=${ETH}
> + setup_eth
> NS1=""
> else
> validate_root_exec
> @@ -191,6 +214,8 @@ exec_xskxceiver
>
> if [ -z $ETH ]; then
> cleanup_exit ${VETH0} ${VETH1} ${NS1}
> +else
> + cleanup_eth
> fi
>
> failures=0
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-11-30 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 9:41 [PATCH bpf-next] selftests: xsk: changes for setting up NICs to run xsk self-tests Tirthendu Sarkar
2022-11-30 11:57 ` Maciej Fijalkowski [this message]
2022-11-30 12:13 ` Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4dFR9oR3AAIcPlB@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tirthendu.sarkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).