From: Brian Masney <bmasney@redhat.com>
To: Tianhao Chai <cth451@gmail.com>
Cc: irusskikh@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: atlantic: fix check for invalid ethernet addresses
Date: Wed, 30 Nov 2022 13:47:06 -0500 [thread overview]
Message-ID: <Y4elKoff5qYRJkJw@x1> (raw)
In-Reply-To: <20221130182640.GA394566@cth-desktop-dorm.rtp.nc.cth451.me>
On Wed, Nov 30, 2022 at 01:26:40PM -0500, Tianhao Chai wrote:
> I'm not familar with this particular board, but this probably shouldn't
> be done in kernel. AFAIK uboot allows overriding MAC with env 'ethaddr'.
> uboot then either writes this MAC into DT or calls NIC specific code to
> set the MAC into NIC memory before booting the kernel.
Our Boot Loader is ABL on the Qualcomm platform.
> The other way around I can think of is to use systemd-networkd or some
> other network management daemon to override the mac address as it tries
> to establish a network connection. This might be less hassle if you
> don't want to mess with the boot loader, but for embedded devices you'd
> need a different root fs image for every board.
We'll look into the systemd approach. I see that our board serial number
is available in /sys/devices/soc0/serial_number and we can have a script
generate a MAC address based on that.
> Acked-by: Tianhao Chai <cth451@gmail.com>
Thanks!
Brian
next prev parent reply other threads:[~2022-11-30 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:42 [PATCH] net: atlantic: fix check for invalid ethernet addresses Brian Masney
2022-11-30 17:57 ` Brian Masney
2022-11-30 18:26 ` Tianhao Chai
2022-11-30 18:47 ` Brian Masney [this message]
2022-11-30 19:41 ` Andrew Lunn
2022-11-30 21:08 ` Brian Masney
2022-11-30 21:32 ` Andrew Lunn
2022-11-30 23:12 ` David Laight
2022-12-01 2:22 ` Andrew Lunn
2022-12-01 8:07 ` [EXT] " Igor Russkikh
2022-12-01 13:55 ` Brian Masney
2022-12-01 14:14 ` Andrew Lunn
2022-12-01 15:18 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4elKoff5qYRJkJw@x1 \
--to=bmasney@redhat.com \
--cc=cth451@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).