From: <Daniel.Machon@microchip.com>
To: <dsahern@kernel.org>
Cc: <netdev@vger.kernel.org>, <stephen@networkplumber.org>,
<petrm@nvidia.com>, <maxime.chevallier@bootlin.com>,
<vladimir.oltean@nxp.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH iproute2-next v2 1/2] dcb: add new pcp-prio parameter to dcb app
Date: Fri, 2 Dec 2022 08:45:45 +0000 [thread overview]
Message-ID: <Y4m925XVWIeeunLX@DEN-LT-70577> (raw)
In-Reply-To: <0642f8ab-63be-7db2-bd7c-16f19a3bdddc@kernel.org>
> On 11/28/22 5:38 AM, Daniel Machon wrote:
> > @@ -344,6 +420,17 @@ static int dcb_app_print_key_dscp(__u16 protocol)
> > return print_uint(PRINT_ANY, NULL, "%d:", protocol);
> > }
> >
> > +static int dcb_app_print_key_pcp(__u16 protocol)
> > +{
> > + /* Print in numerical form, if protocol value is out-of-range */
> > + if (protocol > 15) {
>
> 15 is used in a number of places in this patch. What's the significance
> and can you give it a name that identifies the meaning? i.e., protocol
> is a u16 why the 15 limit? (and update all places accordingly)
Hi David,
As Petr pointed out. The value 15 is the maximum number of PCP+DEI
values (0-7 for DEI=0 and 8-15 for DEI=1) I will add the suggested
change in a new version.
/Daniel
next prev parent reply other threads:[~2022-12-02 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 12:38 [PATCH iproute2-next v2 0/2] Add pcp-prio and new apptrust subcommand Daniel Machon
2022-11-28 12:38 ` [PATCH iproute2-next v2 1/2] dcb: add new pcp-prio parameter to dcb app Daniel Machon
2022-11-29 9:35 ` Petr Machata
2022-12-01 6:43 ` David Ahern
2022-12-01 10:57 ` Petr Machata
2022-12-01 14:10 ` Petr Machata
2022-12-02 8:45 ` Daniel.Machon [this message]
2022-11-28 12:38 ` [PATCH iproute2-next v2 2/2] dcb: add new subcommand for apptrust Daniel Machon
2022-11-29 9:24 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4m925XVWIeeunLX@DEN-LT-70577 \
--to=daniel.machon@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=dsahern@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox