From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FA1C4332F for ; Sun, 4 Dec 2022 09:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbiLDJF2 (ORCPT ); Sun, 4 Dec 2022 04:05:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiLDJF1 (ORCPT ); Sun, 4 Dec 2022 04:05:27 -0500 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1AFE15A2C for ; Sun, 4 Dec 2022 01:05:25 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4DCB75C00A4; Sun, 4 Dec 2022 04:05:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 04 Dec 2022 04:05:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1670144723; x=1670231123; bh=lsMlg+nMOAoGyXJiGA9BuKoPOtzB U01frgsFoEFodQ0=; b=s82YG0/dWILhk42KJP4ogCfKqRIkVNt65GmgxHdVxmlN iuOv0V6jvsXaQUWGQ9UD3VquycL1wo9PBt9Wnzl/rF1Y+9vW4BLR2erVL2LbQKRu MikeduMzfJCInE5kkHLdOJ3sactyOQxqtz/Gj/Vtm3i/9+gi/wFX6nlVwP0Hhesb 4bxnNsSnutaoZO845iK11Y4iQEO0APjGf9vBAnhPnZpon8p32OP7Y14LAEf2aBx/ KFR3xwtOszVZUtLjV2KUFurgPeQ1xB4DgifUZXjmKgPTBvyr0K9/6AjuRpkdi3o0 JEvWIgybRfTsySvKMz3bhrB75VM6y/xwxllDrfDJ4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcuufgthhhi mhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrthhtvghrnh ephefhtdejvdeiffefudduvdffgeetieeigeeugfduffdvffdtfeehieejtdfhjeeknecu ffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 4 Dec 2022 04:05:21 -0500 (EST) Date: Sun, 4 Dec 2022 11:05:18 +0200 From: Ido Schimmel To: Leonid Komaryanskiy Cc: netdev@vger.kernel.org, dmytro_firsov@epam.com, petrm@nvidia.com, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Subject: Re: ip_forward notification for driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Dec 01, 2022 at 05:21:10PM +0200, Leonid Komaryanskiy wrote: > We checked netevents (NETEVENT_IPV4_MPATH_HASH_UPDATE and > NETEVENT_IPV4_FWD_UPDATE_PRIORITY_UPDATE) but unfortunately, netevents > notifier doesn't trigger at all in case of changing value in > /proc/sys/net/ipv4/ip_forward. We see, that these events come in the > case of modifying /proc/sys/net/ipv4/fib_multipath_hash_policy, but > not for ip_forward. Shell we prepare an upstream patch with notifier > for ip_forward modify netevent? I believe this is the correct interface to use for this notification, but if you are going to submit such a patch, then it needs to be submitted together with a patch for a driver that listens to the event an acts upon it. New APIs without an upstream user are not allowed. Also, please make sure you add a test under tools/testing/selftests/net/forwarding/. P.S. Please avoid top-posting as explained here: https://docs.kernel.org/process/2.Process.html#mailing-lists