From: Leon Romanovsky <leon@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, yangyingliang@huawei.com
Subject: Re: [patch net-next RFC 0/7] devlink: make sure devlink port registers/unregisters only for registered instance
Date: Sun, 4 Dec 2022 13:35:37 +0200 [thread overview]
Message-ID: <Y4yGCTMyV2bdD+05@unreal> (raw)
In-Reply-To: <20221201164608.209537-1-jiri@resnulli.us>
On Thu, Dec 01, 2022 at 05:46:01PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
<...>
> Jiri Pirko (7):
> devlink: Reorder devlink_port_register/unregister() calls to be done
> when devlink is registered
> netdevsim: Reorder devl_port_register/unregister() calls to be done
> when devlink is registered
> mlxsw: Reorder devl_port_register/unregister() calls to be done when
> devlink is registered
> nfp: Reorder devl_port_register/unregister() calls to be done when
> devlink is registered
> mlx4: Reorder devl_port_register/unregister() calls to be done when
> devlink is registered
> mlx5: Reorder devl_port_register/unregister() calls to be done when
> devlink is registered
> devlink: assert if devl_port_register/unregister() is called on
> unregistered devlink instance
Thanks, it is more clear now what you wanted.
Everything here looks ok, but can you please find better titles for the
commit messages? They are too long.
Not related to the series, but spotted during the code review,
It will be nice if you can get rid of devlink_port->registered and rely
xarray marks for that. It will be cleaner and aligned with devlink object.
Thanks
next prev parent reply other threads:[~2022-12-04 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:46 [patch net-next RFC 0/7] devlink: make sure devlink port registers/unregisters only for registered instance Jiri Pirko
2022-12-01 16:46 ` [patch net-next RFC 1/7] devlink: Reorder devlink_port_register/unregister() calls to be done when devlink is registered Jiri Pirko
2022-12-01 16:46 ` [patch net-next RFC 2/7] netdevsim: Reorder devl_port_register/unregister() " Jiri Pirko
2022-12-01 16:46 ` [patch net-next RFC 3/7] mlxsw: " Jiri Pirko
2022-12-01 16:46 ` [patch net-next RFC 4/7] nfp: " Jiri Pirko
2022-12-01 16:46 ` [patch net-next RFC 5/7] mlx4: " Jiri Pirko
2022-12-01 16:46 ` [patch net-next RFC 6/7] mlx5: " Jiri Pirko
2022-12-01 16:46 ` [patch net-next RFC 7/7] devlink: assert if devl_port_register/unregister() is called on unregistered devlink instance Jiri Pirko
2022-12-04 11:40 ` Leon Romanovsky
2022-12-05 9:59 ` Jiri Pirko
2022-12-04 11:35 ` Leon Romanovsky [this message]
2022-12-05 10:00 ` [patch net-next RFC 0/7] devlink: make sure devlink port registers/unregisters only for registered instance Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4yGCTMyV2bdD+05@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).