netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: "David Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	netdev@vger.kernel.org, oss-drivers@corigine.com,
	"Yinjun Zhang" <yinjun.zhang@corigine.com>,
	"Richard Donkin" <richard.donkin@corigine.com>,
	"Niklas Söderlund" <niklas.soderlund@corigine.com>
Subject: Re: [PATCH net] nfp: correct desc type when header dma len is 4096
Date: Sun, 4 Dec 2022 15:01:02 +0200	[thread overview]
Message-ID: <Y4yaDtOYppIAVSxS@unreal> (raw)
In-Reply-To: <20221202134646.311108-1-simon.horman@corigine.com>

On Fri, Dec 02, 2022 at 02:46:46PM +0100, Simon Horman wrote:
> From: Yinjun Zhang <yinjun.zhang@corigine.com>
> 
> When there's only one buffer to dma and its length is 4096, then
> only one data descriptor is needed to carry it according to current
> descriptor definition. So the descriptor type should be `simple`
> instead of `gather`, the latter requires more than one descriptor,
> otherwise it'll be dropped by application firmware.
> 
> Fixes: c10d12e3dce8 ("nfp: add support for NFDK data path")
> Fixes: d9d950490a0a ("nfp: nfdk: implement xdp tx path for NFDK")
> Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> Reviewed-by: Richard Donkin <richard.donkin@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
> ---
>  drivers/net/ethernet/netronome/nfp/nfdk/dp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

  reply	other threads:[~2022-12-04 13:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 13:46 [PATCH net] nfp: correct desc type when header dma len is 4096 Simon Horman
2022-12-04 13:01 ` Leon Romanovsky [this message]
2022-12-04 23:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4yaDtOYppIAVSxS@unreal \
    --to=leon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=richard.donkin@corigine.com \
    --cc=simon.horman@corigine.com \
    --cc=yinjun.zhang@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).