From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next 3/4] drivers/net/phy: Add driver for the onsemi NCN26000 10BASE-T1S PHY
Date: Sun, 4 Dec 2022 18:23:49 +0100 [thread overview]
Message-ID: <Y4zXpWEo5rJdNecG@lunn.ch> (raw)
In-Reply-To: <Y4zQNHEkWQG+C/Oj@shell.armlinux.org.uk>
> > +
> > + // bring up the link (link_ctrl is mapped to BMCR_ANENABLE)
> > + // clear also ISOLATE mode and Collision Test
> > + return phy_write(phydev, MII_BMCR, BMCR_ANENABLE);
>
> You always use AN even when ethtool turns off AN? If AN is mandatory,
> it seems there should be some way that phylib can force that to be
> the case.
Hi Russell
The comment is trying to explain that the bit BMCR_ANENABLE does not
actually mean Enable Autoneg. Since AN is not supported by T1S PHYs,
and the standard, some vendors have repurposed this bit.
Maybe we need BMCR_T1S_LINK_CTRL, local to this driver.
Andrew
next prev parent reply other threads:[~2022-12-04 17:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1670119328.git.piergiorgio.beruto@gmail.com>
2022-12-04 2:30 ` [PATCH net-next 1/4] net/ethtool: Add netlink interface for the PLCA RS Piergiorgio Beruto
2022-12-04 2:37 ` Randy Dunlap
2022-12-04 2:49 ` Piergiorgio Beruto
2022-12-04 3:01 ` Randy Dunlap
2022-12-04 2:30 ` [PATCH net-next 2/4] phylib: Add support for 10BASE-T1S link modes and PLCA config Piergiorgio Beruto
2022-12-04 16:45 ` Russell King (Oracle)
2022-12-04 18:04 ` Piergiorgio Beruto
2022-12-04 18:12 ` Andrew Lunn
2022-12-04 20:09 ` Piergiorgio Beruto
2022-12-04 2:31 ` [PATCH net-next 3/4] drivers/net/phy: Add driver for the onsemi NCN26000 10BASE-T1S PHY Piergiorgio Beruto
2022-12-04 16:52 ` Russell King (Oracle)
2022-12-04 17:23 ` Andrew Lunn [this message]
2022-12-04 18:00 ` Andrew Lunn
2022-12-04 20:11 ` Piergiorgio Beruto
2022-12-04 18:40 ` Piergiorgio Beruto
2022-12-04 18:58 ` Andrew Lunn
2022-12-04 19:48 ` Piergiorgio Beruto
2022-12-04 2:32 ` [PATCH net-next 4/4] driver/ncn26000: add PLCA support Piergiorgio Beruto
2022-12-04 17:06 ` Russell King (Oracle)
2022-12-04 17:36 ` Andrew Lunn
2022-12-04 18:48 ` Andrew Lunn
2022-12-04 20:09 ` Piergiorgio Beruto
2022-12-04 20:22 ` Russell King (Oracle)
2022-12-04 20:33 ` Piergiorgio Beruto
2022-12-04 20:29 ` Piergiorgio Beruto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4zXpWEo5rJdNecG@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).