From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next 1/2] ethtool: update UAPI files
Date: Sun, 4 Dec 2022 18:49:45 +0100 [thread overview]
Message-ID: <Y4zduT5aHd4vxQZL@lunn.ch> (raw)
In-Reply-To: <Y4zVMj7rOkyA12uA@shell.armlinux.org.uk>
On Sun, Dec 04, 2022 at 05:13:22PM +0000, Russell King (Oracle) wrote:
> On Sun, Dec 04, 2022 at 03:38:37AM +0100, Piergiorgio Beruto wrote:
>
> NAK. No description of changes.
Hi Piergiorgio
Look at the previous examples of this:
commit 41fddc0eb01fcd8c5a47b415d3faecd714652513
Author: Michal Kubecek <mkubecek@suse.cz>
Date: Mon Jun 13 23:50:26 2022 +0200
update UAPI header copies
Update to kernel v5.18.
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> > diff --git a/uapi/linux/ethtool.h b/uapi/linux/ethtool.h
> > index 944711cfa6f6..5f414deacf23 100644
> > --- a/uapi/linux/ethtool.h
> > +++ b/uapi/linux/ethtool.h
> > @@ -11,14 +11,16 @@
> > * Portions Copyright (C) Sun Microsystems 2008
> > */
> >
> > -#ifndef _LINUX_ETHTOOL_H
> > -#define _LINUX_ETHTOOL_H
> > +#ifndef _UAPI_LINUX_ETHTOOL_H
> > +#define _UAPI_LINUX_ETHTOOL_H
Maybe ask Michal Kubecek how he does this. It does not appear to be a
straight copy of the headers.
Andrew
next prev parent reply other threads:[~2022-12-04 17:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 2:37 [PATCH net-next 0/2] ethtool: add PLCA RS support Piergiorgio Beruto
2022-12-04 2:38 ` [PATCH net-next 1/2] ethtool: update UAPI files Piergiorgio Beruto
2022-12-04 17:13 ` Russell King (Oracle)
2022-12-04 17:49 ` Andrew Lunn [this message]
2022-12-04 20:14 ` Piergiorgio Beruto
2022-12-04 21:16 ` Piergiorgio Beruto
2022-12-04 21:25 ` Michal Kubecek
2022-12-04 21:30 ` Piergiorgio Beruto
2022-12-04 2:40 ` [PATCH net-next 2/2] ethtool: Add support for IEEE 802.3cg-2019 Clause 148 - PLCA RS Piergiorgio Beruto
2022-12-06 2:05 ` [PATCH net-next 0/2] ethtool: add PLCA RS support Jakub Kicinski
2022-12-06 4:11 ` Jakub Kicinski
2022-12-06 13:27 ` Piergiorgio Beruto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4zduT5aHd4vxQZL@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).