From: Leon Romanovsky <leon@kernel.org>
To: Yuan Can <yuancan@huawei.com>
Cc: shshaikh@marvell.com, manishc@marvell.com,
GR-Linux-NIC-Dev@marvell.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
rajesh.borundia@qlogic.com, sucheta.chakraborty@qlogic.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net v2] drivers: net: qlcnic: Fix potential memory leak in qlcnic_sriov_init()
Date: Wed, 7 Dec 2022 11:14:43 +0200 [thread overview]
Message-ID: <Y5BZg4kEl8X05tD2@unreal> (raw)
In-Reply-To: <20221207085410.123938-1-yuancan@huawei.com>
On Wed, Dec 07, 2022 at 08:54:10AM +0000, Yuan Can wrote:
> If vp alloc failed in qlcnic_sriov_init(), all previously allocated vp
> needs to be freed.
>
> Fixes: f197a7aa6288 ("qlcnic: VF-PF communication channel implementation")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
> Changes in v2:
> - free all vp before destroy_workqueue(bc->bc_trans_wq)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2022-12-07 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 8:54 [PATCH net v2] drivers: net: qlcnic: Fix potential memory leak in qlcnic_sriov_init() Yuan Can
2022-12-07 9:14 ` Leon Romanovsky [this message]
2022-12-09 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5BZg4kEl8X05tD2@unreal \
--to=leon@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rajesh.borundia@qlogic.com \
--cc=shshaikh@marvell.com \
--cc=sucheta.chakraborty@qlogic.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox