From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB61C352A1 for ; Wed, 7 Dec 2022 13:58:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbiLGN6L (ORCPT ); Wed, 7 Dec 2022 08:58:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbiLGN54 (ORCPT ); Wed, 7 Dec 2022 08:57:56 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA31B5B85D for ; Wed, 7 Dec 2022 05:57:55 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id m18so12626909eji.5 for ; Wed, 07 Dec 2022 05:57:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6R6RPhEMnDDwr3AtfavGsulA8T0smLmthgPNwTxk7do=; b=rFZLKzuxSCXL0/RVKoW+2JN4Rhlu7jPPPMgyWfU8TeLIsLHk1bujos1jkakP3oAw7p 0bemsdoifiqJFY069nVhiehDpd+hhgQPnV4RaSLdEJiEQ6Hgudm4NKoOxgoHWPoHHK8G PjCHChNsPqqdvW2kF1dWmNzrQSPGOq7lqcy6+rqFOdRZ3SwMQqQLDNwbSMQ9qIoaHQJo 3dHSKfM4LAu81L+MBAw0oYiw7jaAHNuxK5AByyHBQMv9BND8lpLe76R24GF22PrRt6Uh MagZbcVq7S0RWa9EFh2wA7A/G2kBOtOhlV5pg0THEOpcqV/EO001P1iFCFWfrHedZ7yr UEyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6R6RPhEMnDDwr3AtfavGsulA8T0smLmthgPNwTxk7do=; b=BBYaPRspAiVa/QcbwCWiMHev9nI0cWlAdnkyY/hojtmVcDf/ImWPMxLQudsS0IS8sB AHe93njK6Z9IYPqZbI5ugULAxt6mr/8YQa9MyTLI9LXpjmn1Hn3q49JKsLy+/bu0EQTU NoGPdB+NdPhK3d+Lc8KX0kEaybH2Luuq4qWupyjuf00O3//iMCBxqKZgN5jLyqOgN7Y2 Wki9/k7oE4SyKmPxn/GkbQEC+ni9Q1L8/izkHj0vWzeufKqFF9ft1xx3UeJQOxsAA1DY OZ5abJQQ1RkqeIXnDXzfVv6MOq5cFiUJ8jIrBlmJJmSFH2GYbTA7QMJnz+aSdK5lnqlg HaRQ== X-Gm-Message-State: ANoB5pleqUigCRYqkEe/klngGTmAVl4O8zypw1vIAkivaZhM8BsnALL9 Ai8D1ZAIU4JhZ6K6EtuQK6iEprH0DDepcIMQKXo= X-Google-Smtp-Source: AA0mqf4cs3jAxjVlM/djRjoy8ts1G83WugKPd01O9HoGR4w0IADcpL+ZW8XmzZBxKvAi0gGDSHR4Qg== X-Received: by 2002:a17:906:ef1:b0:78d:260d:a6e4 with SMTP id x17-20020a1709060ef100b0078d260da6e4mr75140483eji.93.1670421474344; Wed, 07 Dec 2022 05:57:54 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id b7-20020a17090630c700b007b790c18264sm8500628ejb.159.2022.12.07.05.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 05:57:53 -0800 (PST) Date: Wed, 7 Dec 2022 14:57:52 +0100 From: Jiri Pirko To: Yongqiang Liu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, macro@orcam.me.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ralf@linux-mips.org, jeff@garzik.org, akpm@linux-foundation.org, zhangxiaoxu5@huawei.com Subject: Re: [PATCH net] net: defxx: Fix missing err handling in dfx_init() Message-ID: References: <20221207072045.604872-1-liuyongqiang13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207072045.604872-1-liuyongqiang13@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Dec 07, 2022 at 08:20:45AM CET, liuyongqiang13@huawei.com wrote: >When eisa_driver_register() or tc_register_driver() failed, >the modprobe defxx would fail with some err log as follows: > > Error: Driver 'defxx' is already registered, aborting... > >Fix this issue by adding err hanling in dfx_init(). > >Fixes: e89a2cfb7d7b5 ("[TC] defxx: TURBOchannel support") >Signed-off-by: Yongqiang Liu Reviewed-by: Jiri Pirko