From: Jiri Pirko <jiri@resnulli.us>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net v2] net: plip: don't call kfree_skb/dev_kfree_skb() under spin_lock_irq()
Date: Wed, 7 Dec 2022 14:54:41 +0100 [thread overview]
Message-ID: <Y5CbIW/6LsHGbQg3@nanopsycho> (raw)
In-Reply-To: <20221207015310.2984909-1-yangyingliang@huawei.com>
Wed, Dec 07, 2022 at 02:53:10AM CET, yangyingliang@huawei.com wrote:
>It is not allowed to call kfree_skb() or consume_skb() from
>hardware interrupt context or with interrupts being disabled.
>So replace kfree_skb/dev_kfree_skb() with dev_kfree_skb_irq()
>and dev_consume_skb_irq() under spin_lock_irq().
>
>Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
I wonder if anyone is actually using PLIP these days :)
next prev parent reply other threads:[~2022-12-07 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 1:53 [PATCH net v2] net: plip: don't call kfree_skb/dev_kfree_skb() under spin_lock_irq() Yang Yingliang
2022-12-07 13:54 ` Jiri Pirko [this message]
2022-12-08 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5CbIW/6LsHGbQg3@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox