From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E1FC352A1 for ; Wed, 7 Dec 2022 17:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbiLGRsQ (ORCPT ); Wed, 7 Dec 2022 12:48:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbiLGRsP (ORCPT ); Wed, 7 Dec 2022 12:48:15 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA7C1654C8; Wed, 7 Dec 2022 09:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=b6WLhD+PnTypQlZbVHDcD5fVsl+hiijx+vNoemLYbyQ=; b=LxVvk0+YFrTSJmNOhh2TqGO7TD nZQlggmTyUV4Gqn9zGNXwySY01QhmlJExqa86qvxOMFsdbYGZtkRetku4SAYlw4298IKWifYASgvo 6l+h4OaJFEqkIE1M0T2tk88hi4ui2Z2pJdQcnp5DfG//YrAJlWdo2KLbA/u5wVp4+6kE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p2yWZ-004fxP-Rq; Wed, 07 Dec 2022 18:48:03 +0100 Date: Wed, 7 Dec 2022 18:48:03 +0100 From: Andrew Lunn To: Piergiorgio Beruto Cc: Jakub Kicinski , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Oleksij Rempel Subject: Re: [PATCH v5 net-next 1/5] net/ethtool: add netlink interface for the PLCA RS Message-ID: References: <350e640b5c3c7b9c25f6fd749dc0237e79e1c573.1670371013.git.piergiorgio.beruto@gmail.com> <20221206195014.10d7ec82@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > And only return the actual version value, not the 0x0A. > About this, at the moment I am reporting the 0x0A to allow in the future > possible extensions of the standard. A single byte for the version may > be too limited given this technology is relatively fresh. > What you think of this? What does the standards document say about this 0x0A? Andrew