* [PATCH linux-next] net: hns3: use strscpy() to instead of strncpy()
@ 2022-12-08 11:53 yang.yang29
2022-12-08 16:11 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: yang.yang29 @ 2022-12-08 11:53 UTC (permalink / raw)
To: salil.mehta
Cc: yisen.zhuang, davem, edumazet, kuba, pabeni, brianvv, netdev,
linux-kernel, xu.panda, yang.yang29
From: Xu Panda <xu.panda@zte.com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
index cdf76fb58d45..55306fe8a540 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
@@ -639,13 +639,11 @@ static void hns3_get_drvinfo(struct net_device *netdev,
return;
}
- strncpy(drvinfo->driver, dev_driver_string(&h->pdev->dev),
+ strscpy(drvinfo->driver, dev_driver_string(&h->pdev->dev),
sizeof(drvinfo->driver));
- drvinfo->driver[sizeof(drvinfo->driver) - 1] = '\0';
- strncpy(drvinfo->bus_info, pci_name(h->pdev),
+ strscpy(drvinfo->bus_info, pci_name(h->pdev),
sizeof(drvinfo->bus_info));
- drvinfo->bus_info[ETHTOOL_BUSINFO_LEN - 1] = '\0';
fw_version = priv->ae_handle->ae_algo->ops->get_fw_version(h);
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] net: hns3: use strscpy() to instead of strncpy()
2022-12-08 11:53 [PATCH linux-next] net: hns3: use strscpy() to instead of strncpy() yang.yang29
@ 2022-12-08 16:11 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2022-12-08 16:11 UTC (permalink / raw)
To: yang.yang29
Cc: salil.mehta, yisen.zhuang, davem, edumazet, kuba, pabeni, brianvv,
netdev, linux-kernel, xu.panda
On Thu, Dec 08, 2022 at 07:53:25PM +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
This change looks good to me, although it should probably be
tagged for 'net-next' rather than 'linux-next'.
[PATCH net-next] net: hns3: use strscpy() to instead of strncpy
That notwithstanding,
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-08 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-08 11:53 [PATCH linux-next] net: hns3: use strscpy() to instead of strncpy() yang.yang29
2022-12-08 16:11 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).