From: Andrew Lunn <andrew@lunn.ch>
To: "mengyuanlou@net-swift.com" <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com
Subject: Re: [PATCH net-next v2] net: ngbe: Add ngbe mdio bus driver.
Date: Sun, 11 Dec 2022 12:28:51 +0100 [thread overview]
Message-ID: <Y5W+86YXppK2NocE@lunn.ch> (raw)
In-Reply-To: <8BEEC6D9-EB5F-4A66-8BFD-E8FEE4EB723F@net-swift.com>
> >> +static void ngbe_up(struct ngbe_adapter *adapter)
> >> +{
> >> + struct ngbe_hw *hw = &adapter->hw;
> >> +
> >> + pci_set_master(adapter->pdev);
> >> + if (hw->gpio_ctrl)
> >> + /* gpio0 is used to power on control*/
> >> + wr32(&hw->wxhw, NGBE_GPIO_DR, 0);
> >
> > Control of what?
> Control for sfp modules power down/up.
> The chip has not i2c interface, so I do not use phylink.
Please give this a better name. Is this connected to the TX_DISABLE
pin of the SFP, or the transmit and receiver power pins?
If you don't have the I2C bus, i'm wondering how you can actually
driver the SFP and the MAC. You have no idea what has been
inserted. Is it actually an SFF, not an SFP? Do you have any of the
GPIOs normally associated with an SFP? TX_DISABLE, LOS, TX_FAULT?
Andrew
next prev parent reply other threads:[~2022-12-11 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 11:40 [PATCH net-next v2] net: ngbe: Add ngbe mdio bus driver Mengyuan Lou
2022-12-09 3:42 ` Jakub Kicinski
2022-12-10 10:47 ` Andrew Lunn
2022-12-11 7:35 ` mengyuanlou
2022-12-11 11:28 ` Andrew Lunn [this message]
2022-12-11 11:53 ` mengyuanlou
2022-12-11 12:02 ` Andrew Lunn
2022-12-11 12:31 ` mengyuanlou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5W+86YXppK2NocE@lunn.ch \
--to=andrew@lunn.ch \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).