From: Hangbin Liu <liuhangbin@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Toppins <jtoppins@redhat.com>,
Paolo Abeni <pabeni@redhat.com>, liali <liali@redhat.com>
Subject: Re: [PATCH net 1/3] bonding: access curr_active_slave with rtnl_dereference
Date: Mon, 12 Dec 2022 09:57:05 +0800 [thread overview]
Message-ID: <Y5aKcYFp9ounWJM1@Laptop-X1> (raw)
In-Reply-To: <CANn89iKh3M+mL_Yh_oAX0T6b9mAu6_JZKZwunH377bJNusuTKA@mail.gmail.com>
On Sat, Dec 10, 2022 at 06:41:01PM +0100, Eric Dumazet wrote:
> Now, you post a patch for bond_miimon_commit() which already has :
>
> if (slave == rcu_access_pointer(bond->curr_active_slave))
> goto do_failover;
>
> So really it is a matter of consistency in _this_ function, which is
> run under RTNL for sure.
Ah, thanks for the explanation.
> It is also a patch for net-next tree, because it fixes no bug.
>
> I would not add a Fixes: tag to avoid dealing with useless backports.
OK, I will do as your suggest.
Cheers
Hangbin
next prev parent reply other threads:[~2022-12-12 1:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 10:13 [PATCH net 0/3] Bonding: fix high prio not effect issue Hangbin Liu
2022-12-09 10:13 ` [PATCH net 1/3] bonding: access curr_active_slave with rtnl_dereference Hangbin Liu
2022-12-09 23:46 ` Saeed Mahameed
2022-12-09 23:58 ` Eric Dumazet
2022-12-10 12:28 ` Hangbin Liu
2022-12-10 17:41 ` Eric Dumazet
2022-12-12 1:57 ` Hangbin Liu [this message]
2022-12-09 10:13 ` [PATCH net 2/3] bonding: do failover when high prio link up Hangbin Liu
2022-12-10 0:03 ` Saeed Mahameed
2022-12-10 12:23 ` Hangbin Liu
2022-12-09 10:13 ` [PATCH net 3/3] selftests: bonding: add bonding prio option test Hangbin Liu
2022-12-10 0:01 ` [PATCH net 0/3] Bonding: fix high prio not effect issue Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5aKcYFp9ounWJM1@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox