* [PATCH net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails
@ 2022-12-14 8:01 Gaosheng Cui
2022-12-14 8:10 ` Leon Romanovsky
2022-12-15 13:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Gaosheng Cui @ 2022-12-14 8:01 UTC (permalink / raw)
To: peppe.cavallaro, alexandre.torgue, joabreu, davem, edumazet, kuba,
pabeni, mcoquelin.stm32, ast, daniel, hawk, john.fastabend,
boon.leong.ong, cuigaosheng1
Cc: netdev, linux-stm32, linux-arm-kernel
We should set the return value to -ENOMEM explicitly when
create_singlethread_workqueue() fails in stmmac_dvr_probe(),
otherwise we'll lose the error value.
Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
v2:
- Change title of this patch to be "PATCH net", thanks!
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index ec64b65dee34..c6951c976f5d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -7099,6 +7099,7 @@ int stmmac_dvr_probe(struct device *device,
priv->wq = create_singlethread_workqueue("stmmac_wq");
if (!priv->wq) {
dev_err(priv->device, "failed to create workqueue\n");
+ ret = -ENOMEM;
goto error_wq_init;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails
2022-12-14 8:01 [PATCH net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails Gaosheng Cui
@ 2022-12-14 8:10 ` Leon Romanovsky
2022-12-15 13:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-12-14 8:10 UTC (permalink / raw)
To: Gaosheng Cui
Cc: peppe.cavallaro, alexandre.torgue, joabreu, davem, edumazet, kuba,
pabeni, mcoquelin.stm32, ast, daniel, hawk, john.fastabend,
boon.leong.ong, netdev, linux-stm32, linux-arm-kernel
On Wed, Dec 14, 2022 at 04:01:17PM +0800, Gaosheng Cui wrote:
> We should set the return value to -ENOMEM explicitly when
> create_singlethread_workqueue() fails in stmmac_dvr_probe(),
> otherwise we'll lose the error value.
>
> Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> v2:
> - Change title of this patch to be "PATCH net", thanks!
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
It is so shameful that on Fixed commit, my tag too :(.
Sorry about that.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails
2022-12-14 8:01 [PATCH net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails Gaosheng Cui
2022-12-14 8:10 ` Leon Romanovsky
@ 2022-12-15 13:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-15 13:10 UTC (permalink / raw)
To: Gaosheng Cui
Cc: peppe.cavallaro, alexandre.torgue, joabreu, davem, edumazet, kuba,
pabeni, mcoquelin.stm32, ast, daniel, hawk, john.fastabend,
boon.leong.ong, netdev, linux-stm32, linux-arm-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 14 Dec 2022 16:01:17 +0800 you wrote:
> We should set the return value to -ENOMEM explicitly when
> create_singlethread_workqueue() fails in stmmac_dvr_probe(),
> otherwise we'll lose the error value.
>
> Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
>
> [...]
Here is the summary with links:
- [net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails
https://git.kernel.org/netdev/net/c/2cb815cfc78b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-15 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-14 8:01 [PATCH net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails Gaosheng Cui
2022-12-14 8:10 ` Leon Romanovsky
2022-12-15 13:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).