[patch iproute2-main] devlink: fix mon json output for trap-policer

[patch iproute2-main] devlink: fix mon json output for trap-policer

[Jiri Pirko]

From: Jiri Pirko <jiri@nvidia.com>

There is a json footer missed for trap-policer output in "devlink mon".
So add it and fix the json output.

Fixes: a66af5569337 ("devlink: Add devlink trap policer set and show commands")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
 devlink/devlink.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 11daf0c36e5d..4baac2a8d60f 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -6522,6 +6522,7 @@ static int cmd_mon_show_cb(const struct nlmsghdr *nlh, void *data)
 			return MNL_CB_ERROR;
 		pr_out_mon_header(genl->cmd);
 		pr_out_trap_policer(dl, tb, false);
+		pr_out_mon_footer();
 		break;
 	case DEVLINK_CMD_LINECARD_GET: /* fall through */
 	case DEVLINK_CMD_LINECARD_SET: /* fall through */
-- 
2.37.3

Re: [patch iproute2-main] devlink: fix mon json output for trap-policer

[Ido Schimmel]

On Thu, Dec 15, 2022 at 06:00:56PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> There is a json footer missed for trap-policer output in "devlink mon".
> So add it and fix the json output.
> 
> Fixes: a66af5569337 ("devlink: Add devlink trap policer set and show commands")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Looks like we missed it in commit c4dfddccef4e ("devlink: fix JSON
output of mon command")

Re: [patch iproute2-main] devlink: fix mon json output for trap-policer

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Thu, 15 Dec 2022 18:00:56 +0100 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> There is a json footer missed for trap-policer output in "devlink mon".
> So add it and fix the json output.
> 
> Fixes: a66af5569337 ("devlink: Add devlink trap policer set and show commands")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [iproute2-main] devlink: fix mon json output for trap-policer
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=1e994cf69cfd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html