From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112A2C001B2 for ; Fri, 16 Dec 2022 11:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbiLPLVO (ORCPT ); Fri, 16 Dec 2022 06:21:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230518AbiLPLUz (ORCPT ); Fri, 16 Dec 2022 06:20:55 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2966B34 for ; Fri, 16 Dec 2022 03:20:51 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id co23so2171348wrb.4 for ; Fri, 16 Dec 2022 03:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c8zJd904+IXjpPodDBXcpzzovSChRn9dgEg89jVdTTc=; b=rwC753FZsDUgTG4iIcy926S69sXY8sUHPwYod7qj6vcU/Aab3GdkOxs2e0mkNILo40 EuzGZWQSs+t9TFGViBP0HMSn2f5NA0pEON7drTGWJabe53fS/hClSpNaQd2IHD68Ljri XQ/yG4C+pacM8BubKRno+Iln+lJnd55/H7dKp2pflYml8XZ6pfUDA3JQyAy6+Pml3p/7 uEfIi7EiShHzKM5HwFWYeDR7ipOt1A3fcUuDkVoUp6vj6GKvo3I+3nNSrapQ++X7Sj4l A750lg4s57z9KiCUEsre4OyU1xmWg45pt/SAMR5e2IEFGSrA6pE2EsZrcueaM+CZeXSP 7Q6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c8zJd904+IXjpPodDBXcpzzovSChRn9dgEg89jVdTTc=; b=A9Hu53kyOTNd2KV6qp7yHpyxNoCRVJYBA4A/zT4YTLG8Gk5qFArcVgAqK/opsfaYpl qQQBtW80eGGFZcgZX0zBhWNtvC8GtnugC5ay8e+BB8GDuu5kWn6Giq8ipPtBRW5Rm/9x URs5GHnRDOGPwSiAkBe0FxGHHcPnb3TRjJ3P3xGlVtDPTs36lZs0EilGJNv/YI2l3sDQ dPAnDcJUMG7ZE6wOjy1mrBQF2jiZINdJvoKfPAXRe7tGuPMlsxXW2Eif8+pkDx5Rzd+D xvoSR3GhdTRWVT3KDMEB+xBOe53sDDmxcaPap8aWbbhPYWXG1qlKgt5NrD9Vn4gxnGhi Q32w== X-Gm-Message-State: ANoB5plccWDz6IjEm1DraMkWhSxu6AZdo9rAanUKQn+Xn1P8Q8eKji7x 4EIzDAGfsiMwiIJHxm2XWtWX2g== X-Google-Smtp-Source: AA0mqf5FTRHlnyovbIiVic0ZLreeNyr+YqX6ewUwMmrnndfqEH8iic7W9jiQeCVaZIQ65MZg/fR77Q== X-Received: by 2002:a05:6000:1d9c:b0:242:7eb8:37bf with SMTP id bk28-20020a0560001d9c00b002427eb837bfmr21996245wrb.32.1671189649772; Fri, 16 Dec 2022 03:20:49 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id 1-20020a05600c228100b003d23928b654sm9042343wmf.11.2022.12.16.03.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 03:20:48 -0800 (PST) Date: Fri, 16 Dec 2022 12:20:48 +0100 From: Jiri Pirko To: Daniil Tatianin Cc: Jesse Brandeburg , Tony Nguyen , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Harshitha Ramamurthy , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it Message-ID: References: <20221216091326.1457454-1-d-tatianin@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216091326.1457454-1-d-tatianin@yandex-team.ru> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Dec 16, 2022 at 10:13:26AM CET, d-tatianin@yandex-team.ru wrote: >This fixes a copy-paste issue where dev_err would log the dst mask even >though it is clearly talking about src. > >Found by Linux Verification Center (linuxtesting.org) with the SVACE >static analysis tool. > >Fixes: 0075fa0fadd0a ("i40evf: Add support to apply cloud filters") >Signed-off-by: Daniil Tatianin Reviewed-by: Jiri Pirko