From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Geoff Levand <geoff@infradead.org>,
Jakub Kicinski <kuba@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Paolo Abeni <pabeni@redhat.com>, Petr Machata <petrm@nvidia.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH] net: ks8851: Drop IRQ threading
Date: Fri, 16 Dec 2022 14:32:16 -0800 [thread overview]
Message-ID: <Y5zx8F508bzyy32A@google.com> (raw)
In-Reply-To: <7a50a241-0a93-3e44-bcc7-b9e07c62d616@denx.de>
On Fri, Dec 16, 2022 at 11:19:27PM +0100, Marek Vasut wrote:
> On 12/16/22 22:54, Dmitry Torokhov wrote:
> > On Fri, Dec 16, 2022 at 02:23:04PM +0100, Eric Dumazet wrote:
> > > On Fri, Dec 16, 2022 at 1:47 PM Marek Vasut <marex@denx.de> wrote:
> > > >
> > > > Request non-threaded IRQ in the KSZ8851 driver, this fixes the following warning:
> > > > "
> > > > NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
> > >
> > > This changelog is a bit terse.
> > >
> > > Why can other drivers use request_threaded_irq(), but not this one ?
> >
> > This one actually *has* to use threading, as (as far as I can see) the
> > "lock" that is being taken in ks8851_irq for the SPI variant of the
> > device is actually a mutex, so we have to be able to sleep in the
> > interrupt handler...
>
> So maybe we should use threaded one for the SPI variant and non-threaded one
> for the Parallel bus variant ?
I do not think the threading itself is the issue. I did a quick search
and "Non-RCU local softirq work is pending" seems to be a somewhat
common issue in network drivers. I think you should follow for example
thread in https://lore.kernel.org/all/87y28b9nyn.ffs@tglx/t/ and collect
the trace data and bug tglx and Paul. I see you are even on CC in that
thread...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-12-16 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 12:47 [PATCH] net: ks8851: Drop IRQ threading Marek Vasut
2022-12-16 13:23 ` Eric Dumazet
2022-12-16 21:54 ` Dmitry Torokhov
2022-12-16 22:19 ` Marek Vasut
2022-12-16 22:32 ` Dmitry Torokhov [this message]
2023-05-31 2:19 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5zx8F508bzyy32A@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geoff@infradead.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).