From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7356DC4332F for ; Tue, 20 Dec 2022 22:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbiLTW4b (ORCPT ); Tue, 20 Dec 2022 17:56:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233881AbiLTW42 (ORCPT ); Tue, 20 Dec 2022 17:56:28 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 691111EC54 for ; Tue, 20 Dec 2022 14:56:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=VA52tu3Uk+XRo+XuD4WICwXijV07H/VhVdT4zbt7AZI=; b=Qwninmqfyw0wGGtPtVHYrPAN6B Fag7yMJoPCyEpUgpncPq/p6oDlHMhiOebA1OASQOGmTDtcnAZKsKc/QpajuCKU50MMSiNVff9AOTE ToJ6P0orbapRGTGMeaXyg7ERT0KnEHxK15NfugU+iAfXg70JUMa1Hps7gC171xZVSbOU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p7lX2-00080l-Lz; Tue, 20 Dec 2022 23:56:20 +0100 Date: Tue, 20 Dec 2022 23:56:20 +0100 From: Andrew Lunn To: Jiawen Wu Cc: netdev@vger.kernel.org, mengyuanlou@net-swift.com Subject: Re: [PATCH net-next] net: wangxun: Adjust code structure Message-ID: References: <20221213063543.2408987-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221213063543.2408987-1-jiawenwu@trustnetic.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Dec 13, 2022 at 02:35:43PM +0800, Jiawen Wu wrote: > From: Mengyuan Lou > > Remove useless structs 'txgbe_hw' and 'ngbe_hw' make the codes clear. > And move the same codes which sets MAC address between txgbe and ngbe to > libwx. So this patch appears to do three things. So ideally it should be three patches. I will then but much easier to review. Andrew