From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Xu Liang <lxu@maxlinear.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org, hmehrtens@maxlinear.com,
tmohren@maxlinear.com, mohammad.athari.ismail@intel.com,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net v2] net: phy: mxl-gpy: fix delay time required by loopback disable function
Date: Wed, 21 Dec 2022 12:21:51 +0000 [thread overview]
Message-ID: <Y6L6X2w5EdUBq5ON@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221221094358.29639-1-lxu@maxlinear.com>
Hi,
On Wed, Dec 21, 2022 at 05:43:58PM +0800, Xu Liang wrote:
> GPY2xx devices need 3 seconds to fully switch out of loopback mode
> before it can safely re-enter loopback mode.
Would it be better to record the time that loopback mode is exited,
and then delay an attempt to re-enter loopback mode if it's less than
three seconds since we exited?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-12-21 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 9:43 [PATCH net v2] net: phy: mxl-gpy: fix delay time required by loopback disable function Xu Liang
2022-12-21 12:21 ` Russell King (Oracle) [this message]
2022-12-22 5:23 ` Liang Xu
2022-12-27 10:56 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6L6X2w5EdUBq5ON@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hmehrtens@maxlinear.com \
--cc=kuba@kernel.org \
--cc=lxu@maxlinear.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tmohren@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).