Re: [PATCHv2 net-next] sched: multicast sched extack messages

[Hangbin Liu <liuhangbin@gmail.com>]

Hi Jamal,
On Mon, Dec 26, 2022 at 11:31:24AM -0500, Jamal Hadi Salim wrote:
> My only concern is this is not generic enough i.e can other objects
> outside of filters do this?
> You are still doing it only for the filter (in tfilter_set_nl_ext() -
> sitting in cls_api)
> As i mentioned earlier, actions can also be offloaded independently;
> would this work with actions extack?
> If it wont work then perhaps we should go the avenue of using
> per-object(in this case filter) specific attributes
> to carry the extack as suggested by Jakub earlier.

Yes, I think we can do it on action objects, e.g. call tfilter_set_nl_ext()
in tca_get_fill:

tcf_add_notify() - tca_get_fill()

I will rename tfilter_set_nl_ext() to tc_set_nl_ext(). BTW, should we also
do it in qdisc/ class?

tclass_notify() - tc_fill_tclass()
qdisc_notify() - tc_fill_qdisc()

Thanks
Hangbin