From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Bin Chen <bin.chen@corigine.com>,
Xingfeng Hu <xingfeng.hu@corigine.com>
Subject: Re: [PATCH net-next 2/2] nfp: add DCB IEEE configuration process
Date: Wed, 11 Jan 2023 09:22:08 +0100 [thread overview]
Message-ID: <Y75xsI18uWeWivJ7@corigine.com> (raw)
In-Reply-To: <20230110203808.2952931d@kernel.org>
On Tue, Jan 10, 2023 at 08:38:08PM -0800, Jakub Kicinski wrote:
> On Tue, 10 Jan 2023 13:35:42 +0100 Simon Horman wrote:
> > Basic completion of DCB support, including ETS and other functions.
> > Implemented DCB IEEE callbacks in order to add or remove DSCP to
> > user priority mapping and added DCB IEEE bandwidth percentage checks.
>
> Can you say something about the use case? Some example configurations?
>
> > /* Copyright (C) 2020 Netronome Systems, Inc. */
> > /* Copyright (C) 2021 Corigine, Inc. */
>
> Please sanitize the copyright.
>
> Please squash the two patches. The first one is just noise.
Thanks Jakub,
these patches have a bit of a history which has lead to the problems
you've highlighted. We'll work on cleaning this up in v2.
prev parent reply other threads:[~2023-01-11 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 12:35 [PATCH net-next 0/2] nfp: add DCB IEEE support Simon Horman
2023-01-10 12:35 ` [PATCH net-next 1/2] nfp: add stub implementation of DCB IEEE callbacks Simon Horman
2023-01-10 12:35 ` [PATCH net-next 2/2] nfp: add DCB IEEE configuration process Simon Horman
2023-01-11 4:38 ` Jakub Kicinski
2023-01-11 8:22 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y75xsI18uWeWivJ7@corigine.com \
--to=simon.horman@corigine.com \
--cc=bin.chen@corigine.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=xingfeng.hu@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).