Re: [RFC net-next 07/10] netdevsim: rename a label

Jacob Keller
2022-12-19T18:01:50Z

On 12/16/2022 5:19 PM, Jakub Kicinski wrote:
> err_dl_unregister should unregister the devlink instance.
> Looks like renaming it was missed in one of the reshufflings.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> ---
> drivers/net/netdevsim/dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> index b962fc8e1397..d25f6e86d901 100644
> --- a/drivers/net/netdevsim/dev.c
> +++ b/drivers/net/netdevsim/dev.c
> @@ -1563,7 +1563,7 @@ int nsim_drv_probe(struct nsim_bus_dev *nsim_bus_dev)
> err = devlink_params_register(devlink, nsim_devlink_params,
> ARRAY_SIZE(nsim_devlink_params));
> if (err)
> - goto err_dl_unregister;
> + goto err_resource_unregister;
> nsim_devlink_set_params_init_values(nsim_dev, devlink);
>
> err = nsim_dev_dummy_region_init(nsim_dev, devlink);
> @@ -1629,7 +1629,7 @@ int nsim_drv_probe(struct nsim_bus_dev *nsim_bus_dev)
> err_params_unregister:
> devlink_params_unregister(devlink, nsim_devlink_params,
> ARRAY_SIZE(nsim_devlink_params));
> -err_dl_unregister:
> +err_resource_unregister:
> devl_resources_unregister(devlink);
> err_vfc_free:
> kfree(nsim_dev->vfconfigs);