Re: [RFC net-next 06/10] devlink: don't require setting features before registration

Jakub Kicinski
2023-01-02T23:24:54Z

On Mon, 2 Jan 2023 16:25:18 +0100 Jiri Pirko wrote:
> Sat, Dec 17, 2022 at 02:19:49AM CET, kuba@kernel.org wrote:
> >Requiring devlink_set_features() to be run before devlink is
> >registered is overzealous. devlink_set_features() itself is
> >a leftover from old workarounds which were trying to prevent
> >initiating reload before probe was complete.
>
> Wouldn't it be better to remove this entirely? I don't think it is
> needed anymore.

I think you're right. Since users don't have access to the instance
before it's registered - this flag can have no impact.