Re: [RFC net-next 10/10] netdevsim: register devlink instance before sub-objects

Jiri Pirko
2023-01-03T09:51:27Z

Tue, Jan 03, 2023 at 12:25:46AM CET, kuba@kernel.org wrote:
>On Mon, 2 Jan 2023 14:34:42 +0100 Jiri Pirko wrote:
>> Sat, Dec 17, 2022 at 02:19:53AM CET, kuba@kernel.org wrote:
>> >Move the devlink instance registration up so that all the sub-object
>> >manipulation happens on a valid instance.
>>
>> I wonder, why don't you squash patch 8 to this one and make 1 move, to
>> the fina destination?
>
>I found the squashed version a lot harder to review.

I'm puzzled. Both patches move calls to devl_register/unregister().
The first one moves it, the second one moves it a bit more. What's
making the squashed patch hard to review?