Re: [RFC net-next 00/10] devlink: remove the wait-for-references on unregister

Jacob Keller
2022-12-19T17:38:17Z

On 12/16/2022 5:19 PM, Jakub Kicinski wrote:
> This set is on top of the previous RFC.
>
> Move the registration and unregistration of the devlink instances
> under their instance locks. Don't perform the netdev-style wait
> for all references when unregistering the instance.
>

Could you explain the reasoning/benefits here? I'm sure some of this is
explained in each commit message as well but it would help to understand
the overall series.

> Jakub Kicinski (10):
> devlink: bump the instance index directly when iterating
> devlink: update the code in netns move to latest helpers
> devlink: protect devlink->dev by the instance lock
> devlink: always check if the devlink instance is registered
> devlink: remove the registration guarantee of references
> devlink: don't require setting features before registration
> netdevsim: rename a label
> netdevsim: move devlink registration under the instance lock
> devlink: allow registering parameters after the instance
> netdevsim: register devlink instance before sub-objects
>
> drivers/net/netdevsim/dev.c | 15 +++--
> include/net/devlink.h | 3 +
> net/devlink/basic.c | 64 ++++++++++++------
> net/devlink/core.c | 127 +++++++++++++++++-------------------
> net/devlink/devl_internal.h | 20 ++----
> net/devlink/netlink.c | 19 ++++--
> 6 files changed, 136 insertions(+), 112 deletions(-)
>