From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59DEAC46467 for ; Tue, 3 Jan 2023 09:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236993AbjACJQE (ORCPT ); Tue, 3 Jan 2023 04:16:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236957AbjACJQA (ORCPT ); Tue, 3 Jan 2023 04:16:00 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7643BBE for ; Tue, 3 Jan 2023 01:15:58 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so25742435wma.1 for ; Tue, 03 Jan 2023 01:15:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rHo8Xzze3PBVFK2zU2hBup8w4rK6hXfFEZRWIQGZeYc=; b=HyuFKahhZyvBGLCfqGMbJCh7iNTZ7FaWiA65PSo0pePGtd4FVHTOVAi+U7h2l1SNbd lo9uF7tTJQzh9yBcNbGoJSkRQWv9qWacKra1dB6ixaEYBIAV4diKkEZxm2vIUuVPEZ68 Cu0fiSJfEfkULXku1rzPMdNNRL2DvWL46PxLLB14ii8+cww9UasWjkkt4WgFFXJsAgLv shT67abQ7Elv8OpcYS9iKvCYklh/5wd9iDNhTBIE6JKUf1w07beW+ztoYGZMzHRfUmgz VHXM0mtDu9tzUk5gAMO2KvA2ZWtjkq5QmdbWpf6HRuU1SmdoAalNYtrdPwvcj5Y5zc/d G7Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rHo8Xzze3PBVFK2zU2hBup8w4rK6hXfFEZRWIQGZeYc=; b=EinP/ziCWSvf5siXcmyrzunebEtQ7QJImhQKEImFMYDmKiZIFaTsk45tW/pRwWd7YO eRlcCBF7zPY2+I1HSUjwVyjmCtVYuW1QHAAcXiRvhtuNxe9nKbMN2Isfj8NIazCR4xNn EBSmyg5K5N9YgO7jNiNW/AJuF4FGpK3oDA2XtYmf77N2u6M2qAO/7frnZk/bRzJjtKML 5bCm2yBxeINfGsv5LGUxipKoJWwMrDWFfrThYbAW7xSl2PH12oEkY5UF1LzVhBfW5pRU huw1Kn3LLiBWFl0KfRdaA5T1KCydhU6aZuB2QYeCNP5QJWMSkSSZcqf9pyH2SzkerMjl XaCg== X-Gm-Message-State: AFqh2kqjfsrsnbL+gLjVhTJaJXbRSSXkBahnXyPYdnab75NsybswmC9/ 4DE4Uphmsfjbq5sKuIbFeHcBSw== X-Google-Smtp-Source: AMrXdXv54IL4wF6qUfjXCz4xIw2V01PypRyzoWP3rbvuLu1/SMNzqCCrgBQVi5m/fUtg4+PvXgOGvw== X-Received: by 2002:a05:600c:1ca5:b0:3d1:d746:7bca with SMTP id k37-20020a05600c1ca500b003d1d7467bcamr30813728wms.4.1672737357171; Tue, 03 Jan 2023 01:15:57 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id x15-20020a1c7c0f000000b003c6bbe910fdsm58666345wmc.9.2023.01.03.01.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 01:15:56 -0800 (PST) Date: Tue, 3 Jan 2023 10:15:54 +0100 From: Jiri Pirko To: Sean Anderson Cc: Madalin Bucur , "David S . Miller" , Sean Anderson , netdev@vger.kernel.org, Paolo Abeni , Eric Dumazet , Jakub Kicinski , Christian Zigotzky , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dpaa: Fix dtsec check for PCS availability Message-ID: References: <20230103065038.2174637-1-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103065038.2174637-1-seanga2@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Jan 03, 2023 at 07:50:38AM CET, seanga2@gmail.com wrote: >We want to fail if the PCS is not available, not if it is available. Fix It is odd to read plural maiestaticus in patch desctiption :) Better to stick with describing what code does wrong and then telling the codebase what to do. >this condition. > >Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink") >Reported-by: Christian Zigotzky >Signed-off-by: Sean Anderson Reviewed-by: Jiri Pirko