From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Tariq Toukan" <ttoukan.linux@gmail.com>,
"Andy Gospodarek" <andrew.gospodarek@broadcom.com>,
ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net,
hawk@kernel.org, john.fastabend@gmail.com, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
kpsingh@kernel.org, lorenzo.bianconi@redhat.com,
netdev@vger.kernel.org, bpf@vger.kernel.org,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Andy Gospodarek" <gospo@broadcom.com>,
gal@nvidia.com, "Saeed Mahameed" <saeedm@nvidia.com>,
tariqt@nvidia.com
Subject: Re: [PATCH net-next v2] samples/bpf: fixup some tools to be able to support xdp multibuffer
Date: Wed, 4 Jan 2023 09:44:24 +0100 [thread overview]
Message-ID: <Y7U8aAhdE3TuhtxH@lore-desk> (raw)
In-Reply-To: <20230103172153.58f231ba@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
> On Tue, 03 Jan 2023 16:19:49 +0100 Toke Høiland-Jørgensen wrote:
> > Hmm, good question! I don't think we've ever explicitly documented any
> > assumptions one way or the other. My own mental model has certainly
> > always assumed the first frag would continue to be the same size as in
> > non-multi-buf packets.
>
> Interesting! :) My mental model was closer to GRO by frags
> so the linear part would have no data, just headers.
That is assumption as well.
Regards,
Lorenzo
>
> A random datapoint is that bpf_xdp_adjust_head() seems
> to enforce that there is at least ETH_HLEN.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-04 8:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 17:54 [PATCH net-next v2] samples/bpf: fixup some tools to be able to support xdp multibuffer Andy Gospodarek
2022-06-22 2:00 ` patchwork-bot+netdevbpf
2023-01-03 12:55 ` Tariq Toukan
2023-01-03 15:19 ` Toke Høiland-Jørgensen
2023-01-04 1:21 ` Jakub Kicinski
2023-01-04 8:44 ` Lorenzo Bianconi [this message]
2023-01-04 12:28 ` Toke Høiland-Jørgensen
2023-01-05 1:17 ` Jakub Kicinski
2023-01-05 7:20 ` Tariq Toukan
2023-01-05 15:43 ` Toke Høiland-Jørgensen
2023-01-05 16:57 ` Andy Gospodarek
2023-01-05 18:16 ` Jakub Kicinski
2023-01-06 13:56 ` Andy Gospodarek
2023-01-08 12:33 ` Tariq Toukan
[not found] ` <8369e348-a8ec-cb10-f91f-4277e5041a27@nvidia.com>
2023-01-08 12:42 ` Tariq Toukan
2023-01-09 13:50 ` Toke Høiland-Jørgensen
2023-01-05 22:07 ` Toke Høiland-Jørgensen
2023-01-06 17:54 ` Toke Høiland-Jørgensen
2023-01-05 16:22 ` Andy Gospodarek
2023-01-10 20:59 ` Maxim Mikityanskiy
2023-01-13 21:07 ` Tariq Toukan
2023-01-25 12:49 ` Tariq Toukan
2023-01-05 16:18 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7U8aAhdE3TuhtxH@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=gospo@broadcom.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=songliubraving@fb.com \
--cc=tariqt@nvidia.com \
--cc=toke@redhat.com \
--cc=ttoukan.linux@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox