From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, Tan Tee Min <tee.min.tan@linux.intel.com>,
netdev@vger.kernel.org, sasha.neftin@intel.com,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net-next 2/3] igc: enable Qbv configuration for 2nd GCL
Date: Wed, 4 Jan 2023 09:31:32 +0200 [thread overview]
Message-ID: <Y7UrVHZW32AI82W1@unreal> (raw)
In-Reply-To: <20230103230503.1102426-3-anthony.l.nguyen@intel.com>
On Tue, Jan 03, 2023 at 03:05:02PM -0800, Tony Nguyen wrote:
> From: Tan Tee Min <tee.min.tan@linux.intel.com>
>
> Make reset task only executes for i225 and Qbv disabling to allow
> i226 configure for 2nd GCL without resetting the adapter.
>
> In i226, Tx won't hang if there is a GCL is already running, so in
> this case we don't need to set FutScdDis bit.
>
> Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Tested-by: Naama Meir <naamax.meir@linux.intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 9 +++++----
> drivers/net/ethernet/intel/igc/igc_tsn.c | 13 +++++++++----
> drivers/net/ethernet/intel/igc/igc_tsn.h | 2 +-
> 3 files changed, 15 insertions(+), 9 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-01-04 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 23:05 [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-03 (igc) Tony Nguyen
2023-01-03 23:05 ` [PATCH net-next 1/3] igc: remove I226 Qbv BaseTime restriction Tony Nguyen
2023-01-04 7:30 ` Leon Romanovsky
2023-01-03 23:05 ` [PATCH net-next 2/3] igc: enable Qbv configuration for 2nd GCL Tony Nguyen
2023-01-04 7:31 ` Leon Romanovsky [this message]
2023-01-03 23:05 ` [PATCH net-next 3/3] igc: Remove reset adapter task for i226 during disable tsn config Tony Nguyen
2023-01-04 7:31 ` Leon Romanovsky
2023-01-04 9:00 ` [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-03 (igc) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7UrVHZW32AI82W1@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=tee.min.tan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).