From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
netdev@vger.kernel.org, sasha.neftin@intel.com,
Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net-next 3/3] igc: Remove reset adapter task for i226 during disable tsn config
Date: Wed, 4 Jan 2023 09:31:43 +0200 [thread overview]
Message-ID: <Y7UrX1On4z1DtbTB@unreal> (raw)
In-Reply-To: <20230103230503.1102426-4-anthony.l.nguyen@intel.com>
On Tue, Jan 03, 2023 at 03:05:03PM -0800, Tony Nguyen wrote:
> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
>
> I225 have limitation when programming the BaseTime register which required
> a power cycle of the controller. This limitation already lifted in I226.
> This patch removes the restriction so that when user configure/remove any
> TSN mode, it would not go into power cycle reset adapter.
>
> How to test:
>
> Schedule any gate control list configuration or delete it.
>
> Example:
>
> 1)
>
> BASE_TIME=$(date +%s%N)
> tc qdisc replace dev $interface_name parent root handle 100 taprio \
> num_tc 4 \
> map 3 1 0 2 3 3 3 3 3 3 3 3 3 3 3 3 \
> queues 1@0 1@1 1@2 1@3 \
> base-time $BASE_TIME \
> sched-entry S 0F 1000000 \
> flags 0x2
>
> 2) tc qdisc del dev $intername_name root
>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Tested-by: Naama Meir <naamax.meir@linux.intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 6 +++---
> drivers/net/ethernet/intel/igc/igc_tsn.c | 11 +++--------
> drivers/net/ethernet/intel/igc/igc_tsn.h | 2 +-
> 3 files changed, 7 insertions(+), 12 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-01-04 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 23:05 [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-03 (igc) Tony Nguyen
2023-01-03 23:05 ` [PATCH net-next 1/3] igc: remove I226 Qbv BaseTime restriction Tony Nguyen
2023-01-04 7:30 ` Leon Romanovsky
2023-01-03 23:05 ` [PATCH net-next 2/3] igc: enable Qbv configuration for 2nd GCL Tony Nguyen
2023-01-04 7:31 ` Leon Romanovsky
2023-01-03 23:05 ` [PATCH net-next 3/3] igc: Remove reset adapter task for i226 during disable tsn config Tony Nguyen
2023-01-04 7:31 ` Leon Romanovsky [this message]
2023-01-04 9:00 ` [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-03 (igc) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7UrX1On4z1DtbTB@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).