From: Andrew Lunn <andrew@lunn.ch>
To: Jamie Gloudon <jamie.gloudon@gmx.fr>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
sasha.neftin@intel.com, Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support
Date: Wed, 4 Jan 2023 18:44:09 +0100 [thread overview]
Message-ID: <Y7W66ZstaAb9kIDe@lunn.ch> (raw)
In-Reply-To: <Y7U/4Q0QKtkuexLu@gmx.fr>
> > I don't know this driver at all. What i don't see anywhere here is
> > using the results of the pause auto-neg. Is there some code somewhere
> > that looks at the local and link peer advertising values and runs a
> > resolve algorithm to determine what pause should be used, and program
> > it into the MAC?
> >
> > Andrew
> This is a old patch i had laying around, If i remember correctly, phy->autoneg_advertised plugs in "Link partner
> advertised pause frame use link" line in ethtool everytime the nic renegotiate.
Hi Jamie
Could you point me at the code which interprets the results of the
auto neg and configures the MAC for the correct pause.
Thanks
Andrew
next prev parent reply other threads:[~2023-01-04 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 23:06 [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support Tony Nguyen
2023-01-04 0:34 ` Andrew Lunn
2023-01-04 0:47 ` Andrew Lunn
2023-01-04 8:59 ` Jamie Gloudon
2023-01-04 17:44 ` Andrew Lunn [this message]
2023-01-04 18:52 ` Jamie Gloudon
2023-01-09 8:40 ` Neftin, Sasha
2023-01-09 13:02 ` Andrew Lunn
2023-01-10 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7W66ZstaAb9kIDe@lunn.ch \
--to=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jamie.gloudon@gmx.fr \
--cc=kuba@kernel.org \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).