Re: [PATCH net-next 13/14] devlink: add by-instance dump infra

Jiri Pirko
2023-01-10T14:31:46Z

Mon, Jan 09, 2023 at 08:49:49PM CET, kuba@kernel.org wrote:
>On Sat, 7 Jan 2023 10:23:48 +0100 Jiri Pirko wrote:
>> Hmm.
>> 1) What is wrong of having:
>> .dumpit = devlink_instance_iter_dumpit
>> instead of
>> .dumpit = devlink_instance_iter_dump
>> ?
>> How exactly that decreases readability?
>
>The "it" at the end of the function name is there because do is a C
>keyword, so we can't call the do callback do, we must call it doit.
>
>The further from netlink core we get the more this is an API wart
>and the less it makes sense.
>instance iter dump is closer to plain English.

Hmm, I guess if you are not happy about the callback name, you should
change it, to ".dump" in this case. My point the the naming consistency
between the callback name and the function assigned. But nevermind.