Re: [PATCH net-next 13/14] devlink: add by-instance dump infra

Jakub Kicinski
2023-01-09T19:50:55Z

On Sat, 7 Jan 2023 10:23:48 +0100 Jiri Pirko wrote:
> Hmm.
> 1) What is wrong of having:
> .dumpit = devlink_instance_iter_dumpit
> instead of
> .dumpit = devlink_instance_iter_dump
> ?
> How exactly that decreases readability?

The "it" at the end of the function name is there because do is a C
keyword, so we can't call the do callback do, we must call it doit.

The further from netlink core we get the more this is an API wart
and the less it makes sense.
instance iter dump is closer to plain English.