Netdev List
 help / color / mirror / Atom feed
From: Harald Welte <laforge@gnumonks.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, khc@pm.waw.pl
Subject: Re: [PATCH] net: hdlc: Increase maximum HDLC MTU
Date: Wed, 4 Jan 2023 22:48:56 +0100	[thread overview]
Message-ID: <Y7X0SAF461yyFAgs@nataraja> (raw)
In-Reply-To: <Y7W84D+J4iNx30zx@lunn.ch>

Dear Andrew,

On Wed, Jan 04, 2023 at 06:52:32PM +0100, Andrew Lunn wrote:
 
> This change does appear to change dev->mtu, not just dev->max_mtu?
> So i'm not sure the commit message is correct?

Thanks for your feedback, which seems correct. 

We've been using this patch in production for more than a year, but our
use cases are all using larger MTU so this might have been unnoticed.

I'll investigate and likely we have to introduce a new HDLC_DEFAULT_MTU
of 1500 to achieve backwards compatibility.

-- 
- Harald Welte <laforge@gnumonks.org>          https://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

  reply	other threads:[~2023-01-05 10:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 12:57 [PATCH] net: hdlc: Increase maximum HDLC MTU Harald Welte
2023-01-04 17:52 ` Andrew Lunn
2023-01-04 21:48   ` Harald Welte [this message]
2023-01-05  7:06 ` Krzysztof Hałasa
2023-01-05 13:18   ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7X0SAF461yyFAgs@nataraja \
    --to=laforge@gnumonks.org \
    --cc=andrew@lunn.ch \
    --cc=khc@pm.waw.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox