From: Leon Romanovsky <leon@kernel.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: pkshih@realtek.com, kvalo@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: rtw89: Add missing check for alloc_workqueue
Date: Thu, 5 Jan 2023 11:09:16 +0200 [thread overview]
Message-ID: <Y7aTvDWQnHQfN3su@unreal> (raw)
In-Reply-To: <20230104142353.25093-1-jiasheng@iscas.ac.cn>
On Wed, Jan 04, 2023 at 10:23:53PM +0800, Jiasheng Jiang wrote:
> On Wed, Jan 04, 2023 at 07:41:36PM +0800, Leon Romanovsky wrote:
> > On Wed, Jan 04, 2023 at 05:33:53PM +0800, Jiasheng Jiang wrote:
> >> Add check for the return value of alloc_workqueue since it may return
> >> NULL pointer.
> >>
> >> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> >> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> >> ---
> >> drivers/net/wireless/realtek/rtw89/core.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
> >> index 931aff8b5dc9..006fe0499f81 100644
> >> --- a/drivers/net/wireless/realtek/rtw89/core.c
> >> +++ b/drivers/net/wireless/realtek/rtw89/core.c
> >> @@ -3124,6 +3124,8 @@ int rtw89_core_init(struct rtw89_dev *rtwdev)
> >> INIT_DELAYED_WORK(&rtwdev->cfo_track_work, rtw89_phy_cfo_track_work);
> >> INIT_DELAYED_WORK(&rtwdev->forbid_ba_work, rtw89_forbid_ba_work);
> >> rtwdev->txq_wq = alloc_workqueue("rtw89_tx_wq", WQ_UNBOUND | WQ_HIGHPRI, 0);
> >> + if (!rtwdev->txq_wq)
> >> + return -ENOMEM;
> >
> > While the change is fixing one issue, you are adding another one.
> > There is no destroy of this workqueue if rtw89_load_firmware fails.
>
> Actually, I do not think the missing of destroy_workqueue is introduced by me.
> Even without my patch, the destroy_workqueue is still missing.
Not really, without your change, rtw89_core_init() never failed.
> Anyway, I will submit a v2 that adds the missing destroy_workqueue.
Thanks
>
> Thanks,
> Jiang
>
next prev parent reply other threads:[~2023-01-05 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:23 [PATCH] wifi: rtw89: Add missing check for alloc_workqueue Jiasheng Jiang
2023-01-05 9:09 ` Leon Romanovsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-04 9:33 Jiasheng Jiang
2023-01-04 11:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7aTvDWQnHQfN3su@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiasheng@iscas.ac.cn \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).