Re: [PATCHv3 net-next] sched: multicast sched extack messages

[Hangbin Liu <liuhangbin@gmail.com>]

On Wed, Jan 04, 2023 at 08:01:13PM -0800, Jakub Kicinski wrote:
> On Wed,  4 Jan 2023 17:16:08 +0800 Hangbin Liu wrote:
> > In commit 81c7288b170a ("sched: cls: enable verbose logging") Marcelo
> > made cls could log verbose info for offloading failures, which helps
> > improving Open vSwitch debuggability when using flower offloading.
> > 
> > It would also be helpful if userspace monitor tools, like "tc monitor",
> > could log this kind of message, as it doesn't require vswitchd log level
> > adjusment. Let's add a new function to report the extack message so the
> > monitor program could receive the failures. e.g.
> 
> If you repost this ever again please make sure you include my tag:
> 
> Nacked-by: Jakub Kicinski <kuba@kernel.org>
> 
> I explained to you at least twice why this is a terrible idea,
> and gave you multiple alternatives.

Hi Jakub,

I'm very sorry if this patch makes you feel disturbed. I switched the notification
to NLMSG_ERROR instead of NLMSG_DONE as you pointed out. I also made the
notification only in sched sub-system, not using netlink_ack() globally.
Oh, and forgot to reply to you, I use portid and seq in the notification as all
the tc notifies also use them.

In the last patch, I saw Jamal reply to you about the usability. So I thought
you might reconsider this feature. Now I will stop posting this patch unless
you agree to keep working on this.

Sorry again if I missed any other suggestions from you.

Best regards
Hangbin