From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F98C54EBD for ; Fri, 6 Jan 2023 06:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbjAFGlt (ORCPT ); Fri, 6 Jan 2023 01:41:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjAFGlq (ORCPT ); Fri, 6 Jan 2023 01:41:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46B2A641F; Thu, 5 Jan 2023 22:41:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 05AC2B81C6C; Fri, 6 Jan 2023 06:41:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33132C433D2; Fri, 6 Jan 2023 06:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672987302; bh=lzkrT0JCwviE3EGm/EmzPw8/d4eWbQj9WlhSQzvPbpo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fMAUAd4xS17Y33wWPFyPkBxdkNSMW3jGVvt1lPqi5Fu3uSsxR3yMMoTKlthLHm0YB UoKTC4SEGIg/7bSG/y7CsAY2DVpYZ9IdGgqo7nvoXEe/p60K/84vn2WlAs/CN5JT07 1Z35wQp6gyXxgwIuuiyLQYkO5/yzv5IPP4luScSXzb4itzdpxaUPuwq8KQxFNcYYUI wutSMdypIAEWMpe2MrXoKpKFN1MzhJRMbthJcgm0nK35jHuRkywTh3+bfdImXvefa8 Qypyi30s4gdb/CfHUb44s1bas/VQVT/8lXc4zWpiX2UD646moEtrke+wJ0ec6uTsMt OM9VmIj27/VWQ== Date: Fri, 6 Jan 2023 08:41:38 +0200 From: Leon Romanovsky To: Jakub Kicinski Cc: Saeed Mahameed , Saeed Mahameed , Jason Gunthorpe , linux-rdma@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH mlx5-next 0/8] mlx5 IPsec RoCEv2 support and netdev events fixes in RDMA Message-ID: References: <20230105041756.677120-1-saeed@kernel.org> <20230105103746.13c791d8@kernel.org> <20230105122517.235208c3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105122517.235208c3@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 05, 2023 at 12:25:17PM -0800, Jakub Kicinski wrote: > On Thu, 5 Jan 2023 22:12:28 +0200 Leon Romanovsky wrote: > > > > PR should be based on Linus's -rcX tag and shouldn't include only this patchset. > > > > > > FWIW I don't understand what you mean by this comment. > > > PR should be based on a common ancestor, the -rc tags > > > are just a convenient shorthand. > > > > Linus asked for more than once to use sensible ancestor which is -rc. > > I mean.. as I said using -rc tags makes sanity checking the PRs easier, > so definitely encouraged. > > I was asking more about the second part of your sentence, what do you > mean by "shouldn't include only this patchset" ? When I saw "be applied to net-mlx5 branch", I imagined some branch which is based on net-rc and not on mlx5-next as usual. It looks like Saeed's intention was to say mlx5-next, but he misspelled it. Thanks