Re: [PATCH v2 net-next 5/5] drivers/net/phy: add driver for the onsemi NCN26000 10BASE-T1S PHY

Andrew Lunn
2023-01-09T13:32:33Z

On Mon, Jan 09, 2023 at 12:57:03AM +0100, Piergiorgio Beruto wrote:
> On Sat, Jan 07, 2023 at 07:23:59PM +0100, Andrew Lunn wrote:
> > > +++ b/drivers/net/phy/Kconfig
> > > @@ -264,6 +264,13 @@ config NATIONAL_PHY
> > > help
> > > Currently supports the DP83865 PHY.
> > >
> > > +config NCN26000_PHY
> > > + tristate "onsemi 10BASE-T1S Ethernet PHY"
> > > + help
> > > + Adds support for the onsemi 10BASE-T1S Ethernet PHY.
> > > + Currently supports the NCN26000 10BASE-T1S Industrial PHY
> > > + with MII interface.
> > > +
> > > config NXP_C45_TJA11XX_PHY
> > > tristate "NXP C45 TJA11XX PHYs"
> >
> > These are actually sorted by the tristate string, which is what you
> > see when you use
> >
> > make menuconfig
> >
> > So 'onsemi' should be after 'NXP TJA11xx PHYs support'. Also, all the
> > other entries capitalise the first word.
> As for the order I fixed it. Thanks for noticing.
>
> Regarding the capitalization, I have a little problem here. 'onsemi' is a
> brand and according to company rules it MUST be written all in
> lowercase. I know we're not obliged to follow any company directive here, but
> as wierd as it might sound, I'd rather keep it lowercase just not to get
> comments later on trying to fix this, if you agree...

Linux tends to ignore Marketing, because Marketing tends to change its
mind every 6 months. Also, Linux ignores companies being bought and
sold, changing their name. So this PHY will forever be called whatever
name you give it here. The vitesse PHY driver is an example of
this. They got bought by Microsemi, and then Microchip bought
Microsemi. The PHY driver is still called vitesse.c.

How about using the legal name, 'ON Semiconductor
Corporation'

Andrew