Re: [PATCH RFC v2 0/2] Add I2C fwnode lookup/get interfaces

Wolfram Sang
2023-01-09T11:49:26Z

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

Hi Russell,

thank you for this series!

> This RFC series is intended for the next merge window, but we will need
> to decide how to merge it as it is split across two subsystems. These
> patches have been generated against the net-next, since patch 2 depends
> on a recently merged patch in that tree (which is now in mainline.)

I'd prefer to apply it all to my I2C tree then. I can also provide an
immutable branch for net if that is helpful.

> In order to reduce this complexity, this series adds fwnode interfaces
> to the I2C subsystem to allow I2C adapters to be looked up. I also
> accidentally also converted the I2C clients to also be looked up, so
> I've left that in patch 1 if people think that could be useful - if
> not, I'll remove it.

Because you also converted I2C ACPI to use the new function, I'd say
let's keep it.

> We could also convert the of_* functions to be inline in i2c.h and
> remove the stub of_* functions and exports.

I'd like that.

> Do we want these to live in i2c-core-fwnode.c ? I don't see a Kconfig

I don't think this is enough fwnode-specific code yet for a seperate
source file. I also don't think the helper functions are so large that
there should be an option to compile them out. I am open for other
opinions, but IMHO that part looks good as it is.

> symbol that indicates whether we want fwnode support, and I know there
> are people looking to use software nodes to lookup the SFP I2C bus
> (which is why the manual firmware-specific code in sfp.c is a problem.)

All the best,

Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]