From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED080C5479D for ; Mon, 9 Jan 2023 18:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236831AbjAISrD (ORCPT ); Mon, 9 Jan 2023 13:47:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234251AbjAISrC (ORCPT ); Mon, 9 Jan 2023 13:47:02 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD60CC for ; Mon, 9 Jan 2023 10:47:01 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id d3so10481267plr.10 for ; Mon, 09 Jan 2023 10:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=4xbEUz+l7pEeC2bJ2Istz4CduYkgmHAwjtj7GDJFIrg=; b=gGM5QTd4jsaM5390khMYrTyPZ9B3Wntx0R6uefG5ndPWO8XUfIV1OL70LiklWfJ1mc IvlUz1GiJlG18OEJElMO15xzxSJJ28n//rCrp52037rbP3CB0JDQ8ZuDIQPZO/5Yr+Xd OvtDJGY1dDoRuiATgBKm1kZkGPDSu0TG5F2BWGPEyz1zRlVciNhAxkpsHeP1VoVXaqQA kUiewP5qGEshcInL2Kyfbi4o1V+oJ0nPr50gNYUZcwVLPgXg8q7OMWPKxqT8sMpL0j+e PSNghOAzlC3GRa67MDOynZU1xwr5bauqJK31Dl2NyVWa0lg72RoiBZVSfowmsWyXjGlX lW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4xbEUz+l7pEeC2bJ2Istz4CduYkgmHAwjtj7GDJFIrg=; b=y9TAho+d7Q+bhipokJw3mJsQz7TpzHH0tA9syv+VOBDq9KYm81X/+/Rw628DDBUBNo AlUo5816c99RhyFWWjuW0qieqBRZyxmvdAWXOBFar6+q9VoIfgxaLqh/7I+hSsMmnB08 sCYOk4uT3YZ65LC1HfcOI/RiFXb1aioYn4kzcfK6g9KuwpEkrCgKSVlSq/aP1L1nvwMV MBzN2kStyVLAdS3p3AHVi8ruZfJU7o1vlJ+Sixx110LwTBPOrmivCqy48yHIiUEJ7IUe WTw8Giv5iGpPpbnTIpNOcGx5nkQANpT2sPUkLhYMQDShyC+fbM0Xgu92ph5opqeKxFu9 /4Hg== X-Gm-Message-State: AFqh2kpTNkUOA+EccEag2e8N1Lvegerqd/1qfC+Z9u7rmmRwS8wy4Zey /yXdb2dG6cq+lwwLVpG1HCNPuw== X-Google-Smtp-Source: AMrXdXuSompBiR8zLNRIyy7WUOc4HTorvI5yaJzuY6QIsJ1fL6WFcYcTjnqWV5mN3pMHLLxms+hHig== X-Received: by 2002:a17:902:b713:b0:190:c550:d295 with SMTP id d19-20020a170902b71300b00190c550d295mr64328108pls.9.1673290020669; Mon, 09 Jan 2023 10:47:00 -0800 (PST) Received: from localhost (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id j1-20020a170902c3c100b0018853416bbcsm6539787plj.7.2023.01.09.10.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 10:47:00 -0800 (PST) Date: Mon, 9 Jan 2023 19:46:57 +0100 From: Jiri Pirko To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Horatiu Vultur , UNGLinuxDriver@microchip.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: lan966x: check for ptp to be enabled in lan966x_ptp_deinit() Message-ID: References: <20230109153223.390015-1-clement.leger@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230109153223.390015-1-clement.leger@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Jan 09, 2023 at 04:32:23PM CET, clement.leger@bootlin.com wrote: >If ptp was not enabled due to missing IRQ for instance, >lan966x_ptp_deinit() will dereference NULL pointers. > >Fixes: d096459494a8 ("net: lan966x: Add support for ptp clocks") >Signed-off-by: Clément Léger >Reviewed-by: Horatiu Vultur Reviewed-by: Jiri Pirko